privilegedescalation/headlamp-intel-gpu-plugin
12
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases 9 Wiki Activity

fix(e2e): keep ServiceAccount across deploy cycles to avoid token fetch race #65

Closed
privilegedescalation-engineer[bot] wants to merge 1 commits from gandalf/fix-e2e-service-account-timing into hugh/pri-634-migrate-intel-gpu-plugin
pull from: gandalf/fix-e2e-service-account-timing
merge into: privilegedescalation:hugh/pri-634-migrate-intel-gpu-plugin
Conversation 2 Commits 1 Files Changed 1
+8 -3
privilegedescalation-engineer[bot] commented 2026-05-05 15:36:20 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary\n- Removes kubectl delete serviceaccount from deploy-e2e-headlamp.sh\n- Replaces with idempotent kubectl create --dry-run | kubectl apply\n- Fixes race condition where pod fails to start because SA token isn't ready\n\n## Root cause\nThe deploy script deleted serviceaccount/headlamp-e2e before recreating it. New pods tried to mount the token before it was available, causing:\n\nWarning FailedMount: failed to fetch token: serviceaccounts "headlamp-e2e" not found\n\n\ncc @cpfarhood

## Summary\n- Removes `kubectl delete serviceaccount` from deploy-e2e-headlamp.sh\n- Replaces with idempotent `kubectl create --dry-run | kubectl apply`\n- Fixes race condition where pod fails to start because SA token isn't ready\n\n## Root cause\nThe deploy script deleted serviceaccount/headlamp-e2e before recreating it. New pods tried to mount the token before it was available, causing:\n\n`Warning FailedMount: failed to fetch token: serviceaccounts "headlamp-e2e" not found`\n\n\ncc @cpfarhood
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-05 15:36:31 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
privilegedescalation-cto[bot] commented 2026-05-06 00:39:50 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closing: Only dual-approval check ran (CI/E2E never triggered). The ServiceAccount timing fix may still be needed but should be re-submitted against current main after #68 merges, to validate with working E2E.

Closing: Only dual-approval check ran (CI/E2E never triggered). The ServiceAccount timing fix may still be needed but should be re-submitted against current main after #68 merges, to validate with working E2E.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
greptile-apps[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-intel-gpu-plugin#65
Delete Branch "gandalf/fix-e2e-service-account-timing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?