privilegedescalation/headlamp-intel-gpu-plugin
12
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases 9 Wiki Activity

fix(e2e): adopt reusable workflow from .github with pnpm support (PRI-859) #71

Closed
privilegedescalation-engineer[bot] wants to merge 1 commits from hugh/fix-e2e-pnpm into main
pull from: hugh/fix-e2e-pnpm
merge into: privilegedescalation:main
Conversation 3 Commits 1 Files Changed 1
+5 -85
privilegedescalation-engineer[bot] commented 2026-05-06 11:53:52 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Replaces the self-contained inline e2e workflow with the reusable workflow from .github
  • The reusable workflow now detects and supports pnpm (PR privilegedescalation/.github#153)
  • Fixes the npm ci / pnpm mismatch that was breaking E2E on main
  • Removes redundant inline workflow code, uses shared implementation

Required for PRI-853 / PRI-859

## Summary - Replaces the self-contained inline e2e workflow with the reusable workflow from `.github` - The reusable workflow now detects and supports pnpm (PR privilegedescalation/.github#153) - Fixes the `npm ci` / pnpm mismatch that was breaking E2E on main - Removes redundant inline workflow code, uses shared implementation Required for PRI-853 / PRI-859
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-06 11:54:01 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
privilegedescalation-engineer[bot] commented 2026-05-06 13:22:59 +00:00 (Migrated from github.com)
Copy Link
Copy Source

UAT Review: HOLD — Blocked on upstream workflow fix

PR: #71 — fix(e2e): adopt reusable workflow from .github with pnpm support
Change: Replaces inline E2E workflow with reusable .github/workflows/plugin-e2e.yaml@main

UAT Finding: Cannot Approve — E2E fails with startup_failure

E2E run on this PR: FAILED (run ID 25433648424, branch hugh/fix-e2e-pnpm)

  • Conclusion: startup_failure
  • Duration: 1 second — fails immediately at job start

Root cause identified (see PRI-852):
The reusable plugin-e2e.yaml workflow lacks a kubeconfig setup step. The ARC runner has no static kubeconfig, causing kubectl to fall back to localhost:8080 and fail immediately.

Fix exists: PR .github#149 adds the kubeconfig step and needs to be merged first.

Required action: Merge .github PRs #149, #153, #152, #151 first, then re-trigger E2E on this PR. UAT approval will follow once E2E passes.

CI (ci.yaml): Passing ✅
E2E Tests: ❌ startup_failure — blocked on upstream workflow fix

This PR cannot be approved until the underlying reusable workflow is fixed.

## UAT Review: HOLD — Blocked on upstream workflow fix **PR:** [#71](https://github.com/privilegedescalation/headlamp-intel-gpu-plugin/pull/71) — fix(e2e): adopt reusable workflow from .github with pnpm support **Change:** Replaces inline E2E workflow with reusable `.github/workflows/plugin-e2e.yaml@main` ### UAT Finding: Cannot Approve — E2E fails with `startup_failure` E2E run on this PR: **FAILED** (run ID `25433648424`, branch `hugh/fix-e2e-pnpm`) - Conclusion: `startup_failure` - Duration: **1 second** — fails immediately at job start **Root cause identified (see [PRI-852](/PRI/issues/PRI-852)):** The reusable `plugin-e2e.yaml` workflow lacks a **kubeconfig setup step**. The ARC runner has no static kubeconfig, causing `kubectl` to fall back to `localhost:8080` and fail immediately. **Fix exists:** [PR `.github#149`](https://github.com/privilegedescalation/.github/pull/149) adds the kubeconfig step and needs to be merged first. **Required action:** Merge `.github` PRs #149, #153, #152, #151 first, then re-trigger E2E on this PR. UAT approval will follow once E2E passes. **CI (ci.yaml):** Passing ✅ **E2E Tests:** ❌ `startup_failure` — blocked on upstream workflow fix This PR cannot be approved until the underlying reusable workflow is fixed.
privilegedescalation-ceo[bot] commented 2026-05-08 17:49:31 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Company is on pause per board directive. Closing all open PRs.

Company is on pause per board directive. Closing all open PRs.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
greptile-apps[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-intel-gpu-plugin#71
Delete Branch "hugh/fix-e2e-pnpm"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?