From e17d71bac60f01772f387c16b9e7e58f828a1731 Mon Sep 17 00:00:00 2001 From: Chris Farhood Date: Mon, 11 May 2026 13:07:44 +0000 Subject: [PATCH] Remove non-browser e2e test infrastructure - Delete .github/workflows/e2e.yaml - Delete playwright.config.ts - Delete e2e/ directory (auth.setup.ts, kube-vip.spec.ts) - Delete scripts/deploy-e2e-headlamp.sh and teardown-e2e-headlamp.sh - Remove e2e and e2e:headed scripts from package.json - Remove @playwright/test devDependency Co-Authored-By: Paperclip --- .github/workflows/e2e.yaml | 24 ---- e2e/auth.setup.ts | 69 ----------- e2e/kube-vip.spec.ts | 42 ------- package.json | 7 +- playwright.config.ts | 27 ----- scripts/deploy-e2e-headlamp.sh | 190 ------------------------------- scripts/teardown-e2e-headlamp.sh | 30 ----- 7 files changed, 2 insertions(+), 387 deletions(-) delete mode 100644 .github/workflows/e2e.yaml delete mode 100644 e2e/auth.setup.ts delete mode 100644 e2e/kube-vip.spec.ts delete mode 100644 playwright.config.ts delete mode 100755 scripts/deploy-e2e-headlamp.sh delete mode 100755 scripts/teardown-e2e-headlamp.sh diff --git a/.github/workflows/e2e.yaml b/.github/workflows/e2e.yaml deleted file mode 100644 index 8ac03be..0000000 --- a/.github/workflows/e2e.yaml +++ /dev/null @@ -1,24 +0,0 @@ -name: E2E Tests - -on: - push: - branches: [main] - pull_request: - branches: [main] - workflow_dispatch: - -permissions: - contents: read - -concurrency: - group: e2e-${{ github.repository }} - cancel-in-progress: false - -jobs: - e2e: - uses: privilegedescalation/.github/.github/workflows/plugin-e2e.yaml@main - with: - node-version: '22' - headlamp-version: v0.40.1 - e2e-namespace: headlamp-dev - plugin-name: headlamp-kube-vip diff --git a/e2e/auth.setup.ts b/e2e/auth.setup.ts deleted file mode 100644 index fcd9f7f..0000000 --- a/e2e/auth.setup.ts +++ /dev/null @@ -1,69 +0,0 @@ -import { test as setup, expect, Page } from '@playwright/test'; - -const AUTH_STATE_PATH = 'e2e/.auth/state.json'; - -async function authenticateWithOIDC(page: Page, username: string, password: string): Promise { - await page.goto('/'); - await page.waitForURL('**/login'); - - const popupPromise = page.waitForEvent('popup'); - await page.getByRole('button', { name: /sign in/i }).click(); - const popup = await popupPromise; - - await popup.waitForLoadState('domcontentloaded'); - await popup.waitForLoadState('networkidle'); - - const usernameField = popup.getByRole('textbox', { name: /email or username/i }); - await usernameField.waitFor({ state: 'visible', timeout: 15_000 }); - await usernameField.fill(username); - await popup.getByRole('button', { name: /log in/i }).click(); - - await popup.waitForLoadState('networkidle'); - const passwordField = popup.getByRole('textbox', { name: /password/i }); - await passwordField.waitFor({ state: 'visible', timeout: 15_000 }); - await passwordField.fill(password); - await popup.getByRole('button', { name: /continue|log in/i }).click(); - - await popup.waitForEvent('close', { timeout: 15_000 }); - - await expect(page.getByRole('navigation', { name: 'Navigation' })).toBeVisible({ - timeout: 15_000, - }); -} - -async function authenticateWithToken(page: Page, token: string): Promise { - await page.goto('/'); - await page.waitForURL(/\/(login|token)$/); - - if (page.url().includes('/login')) { - const useTokenBtn = page.getByRole('button', { name: /use a token/i }); - await useTokenBtn.waitFor({ state: 'visible', timeout: 15_000 }); - await useTokenBtn.click(); - await page.waitForURL('**/token'); - } - - await page.getByRole('textbox', { name: /id token/i }).fill(token); - await page.getByRole('button', { name: /authenticate/i }).click(); - - await expect(page.getByRole('navigation', { name: 'Navigation' })).toBeVisible({ - timeout: 15_000, - }); -} - -setup('authenticate with Headlamp', async ({ page }) => { - const username = process.env.AUTHENTIK_USERNAME; - const password = process.env.AUTHENTIK_PASSWORD; - const token = process.env.HEADLAMP_TOKEN; - - if (username && password) { - await authenticateWithOIDC(page, username, password); - } else if (token) { - await authenticateWithToken(page, token); - } else { - throw new Error( - 'Set AUTHENTIK_USERNAME + AUTHENTIK_PASSWORD for OIDC auth, or HEADLAMP_TOKEN for token auth' - ); - } - - await page.context().storageState({ path: AUTH_STATE_PATH }); -}); diff --git a/e2e/kube-vip.spec.ts b/e2e/kube-vip.spec.ts deleted file mode 100644 index 9afe4ac..0000000 --- a/e2e/kube-vip.spec.ts +++ /dev/null @@ -1,42 +0,0 @@ -import { test, expect } from '@playwright/test'; - -test.describe('kube-vip plugin smoke tests', () => { - test('sidebar contains kube-vip entry', async ({ page }) => { - await page.goto('/'); - const sidebar = page.getByRole('navigation', { name: 'Navigation' }); - await expect(sidebar).toBeVisible({ timeout: 15_000 }); - await expect(sidebar.getByRole('button', { name: /kube.vip/i })).toBeVisible(); - }); - - test('kube-vip sidebar entry navigates to kube-vip view', async ({ page }) => { - await page.goto('/'); - const sidebar = page.getByRole('navigation', { name: 'Navigation' }); - await expect(sidebar).toBeVisible({ timeout: 15_000 }); - - const entry = sidebar.getByRole('button', { name: /kube.vip/i }); - await expect(entry).toBeVisible(); - await entry.click(); - - await expect(page).toHaveURL(/kube-vip/); - await expect(page.getByRole('heading', { name: /kube.vip/i })).toBeVisible(); - }); - - test('kube-vip page renders content', async ({ page }) => { - await page.goto('/c/main/kube-vip'); - - await expect(page.getByRole('heading', { name: /kube.vip/i })).toBeVisible({ - timeout: 15_000, - }); - - const hasTable = await page.locator('table').first().isVisible().catch(() => false); - const hasContent = await page.locator('[class*="Mui"]').first().isVisible().catch(() => false); - expect(hasTable || hasContent).toBe(true); - }); - - test('plugin settings page shows kube-vip plugin entry', async ({ page }) => { - await page.goto('/settings/plugins'); - - const pluginEntry = page.locator('text=/kube.vip/i').first(); - await expect(pluginEntry).toBeVisible({ timeout: 30_000 }); - }); -}); diff --git a/package.json b/package.json index 294dcbe..110595c 100644 --- a/package.json +++ b/package.json @@ -23,9 +23,7 @@ "format": "prettier --write src/", "format:check": "prettier --check src/", "test": "vitest run", - "test:watch": "vitest", - "e2e": "playwright test", - "e2e:headed": "playwright test --headed" + "test:watch": "vitest" }, "peerDependencies": { "react": "^18.0.0", @@ -55,7 +53,6 @@ "react-dom": "^18.3.1", "react-router-dom": "^5.3.0", "typescript": "~5.6.2", - "vitest": "^3.2.4", - "@playwright/test": "^1.58.2" + "vitest": "^3.2.4" } } diff --git a/playwright.config.ts b/playwright.config.ts deleted file mode 100644 index b916edf..0000000 --- a/playwright.config.ts +++ /dev/null @@ -1,27 +0,0 @@ -import { defineConfig, devices } from '@playwright/test'; - -export default defineConfig({ - testDir: './e2e', - timeout: 30_000, - expect: { timeout: 10_000 }, - fullyParallel: false, - forbidOnly: !!process.env.CI, - retries: process.env.CI ? 1 : 0, - reporter: 'list', - use: { - baseURL: process.env.HEADLAMP_URL || (() => { throw new Error('HEADLAMP_URL is required — run scripts/deploy-e2e-headlamp.sh first'); })(), - trace: 'on-first-retry', - screenshot: 'only-on-failure', - }, - projects: [ - { name: 'setup', testMatch: /auth\.setup\.ts/, timeout: 60_000 }, - { - name: 'chromium', - use: { - ...devices['Desktop Chrome'], - storageState: 'e2e/.auth/state.json', - }, - dependencies: ['setup'], - }, - ], -}); diff --git a/scripts/deploy-e2e-headlamp.sh b/scripts/deploy-e2e-headlamp.sh deleted file mode 100755 index 3d75c12..0000000 --- a/scripts/deploy-e2e-headlamp.sh +++ /dev/null @@ -1,190 +0,0 @@ -#!/usr/bin/env bash -# deploy-e2e-headlamp.sh -# -# Deploys a stock Headlamp instance with the rook plugin loaded via -# a ConfigMap volume mount. -# -# E2E resources are deployed to the `headlamp-dev` namespace. Nothing -# persists beyond the test run — teardown cleans up all created resources. -# -# Prerequisites: -# - Plugin built (dist/ exists with plugin-main.js + package.json) -# - kubectl configured with cluster access -# -# Environment: -# E2E_NAMESPACE — namespace for E2E Headlamp (default: headlamp-dev) -# E2E_RELEASE — release/resource name prefix (default: headlamp-e2e) -# HEADLAMP_VERSION — Headlamp image tag (default: latest) -set -euo pipefail - -REPO_ROOT="$(cd "$(dirname "$0")/.." && pwd)" -DIST_DIR="$REPO_ROOT/dist" - -E2E_NAMESPACE="${E2E_NAMESPACE:-headlamp-dev}" -E2E_RELEASE="${E2E_RELEASE:-headlamp-e2e}" -HEADLAMP_VERSION="${HEADLAMP_VERSION:-latest}" - -if [ ! -d "$DIST_DIR" ]; then - echo "ERROR: dist/ not found. Run 'pnpm build' first." >&2 - exit 1 -fi - -echo "Checking RBAC permissions in namespace '${E2E_NAMESPACE}'..." -if ! kubectl auth can-i delete configmaps -n "$E2E_NAMESPACE" --quiet 2>/dev/null; then - echo "ERROR: Missing RBAC — cannot delete configmaps in namespace '${E2E_NAMESPACE}'." >&2 - exit 1 -fi - -echo "=== E2E Headlamp Deployment ===" -echo " Image: ghcr.io/headlamp-k8s/headlamp:${HEADLAMP_VERSION}" -echo " Namespace: $E2E_NAMESPACE" -echo " Release: $E2E_RELEASE" - -echo "" -echo "Creating ConfigMap with plugin files..." - -kubectl delete configmap headlamp-kube-vip-plugin \ - -n "$E2E_NAMESPACE" --ignore-not-found - -kubectl create configmap headlamp-kube-vip-plugin \ - -n "$E2E_NAMESPACE" \ - --from-file="$DIST_DIR" \ - --from-file=package.json="$REPO_ROOT/package.json" - -echo "" -echo "Removing any existing E2E deployment (clean-start)..." -kubectl delete deployment "${E2E_RELEASE}" -n "$E2E_NAMESPACE" --ignore-not-found --wait -kubectl delete service "${E2E_RELEASE}" -n "$E2E_NAMESPACE" --ignore-not-found --wait -kubectl delete serviceaccount "${E2E_RELEASE}" -n "$E2E_NAMESPACE" --ignore-not-found --wait - -echo "" -echo "Deploying Headlamp E2E instance..." - -kubectl apply -f - </dev/null; do - ATTEMPTS=$((ATTEMPTS + 1)) - if [ "$ATTEMPTS" -ge "$MAX_ATTEMPTS" ]; then - echo "ERROR: ${SVC_URL} not reachable after $((MAX_ATTEMPTS * 5))s" >&2 - exit 1 - fi - echo " [${ATTEMPTS}/${MAX_ATTEMPTS}] not yet reachable, retrying in 5s..." - sleep 5 -done -echo "" -echo "E2E Headlamp is ready at: ${SVC_URL}" - -echo "" -echo "Creating service account token for E2E auth..." -kubectl create serviceaccount headlamp-e2e-test \ - -n "$E2E_NAMESPACE" --dry-run=client -o yaml | kubectl apply -f - - -TOKEN=$(kubectl create token headlamp-e2e-test -n "$E2E_NAMESPACE" --duration=1h 2>/dev/null || echo "") -if [ -n "$TOKEN" ]; then - echo "HEADLAMP_URL=${SVC_URL}" > "$REPO_ROOT/.env.e2e" - echo "HEADLAMP_TOKEN=${TOKEN}" >> "$REPO_ROOT/.env.e2e" - echo "Wrote .env.e2e with HEADLAMP_URL and HEADLAMP_TOKEN" -else - echo " WARNING: Could not generate token." -fi - -echo "" -echo "E2E deployment complete." diff --git a/scripts/teardown-e2e-headlamp.sh b/scripts/teardown-e2e-headlamp.sh deleted file mode 100755 index eda69c0..0000000 --- a/scripts/teardown-e2e-headlamp.sh +++ /dev/null @@ -1,30 +0,0 @@ -#!/usr/bin/env bash -set -euo pipefail - -REPO_ROOT="$(cd "$(dirname "$0")/.." && pwd)" - -E2E_NAMESPACE="${E2E_NAMESPACE:-headlamp-dev}" -E2E_RELEASE="${E2E_RELEASE:-headlamp-e2e}" - -echo "=== E2E Headlamp Teardown ===" -echo " Namespace: $E2E_NAMESPACE" -echo " Release: $E2E_RELEASE" - -echo "Removing Headlamp Deployment, Service, and ServiceAccount..." -kubectl delete deployment "${E2E_RELEASE}" -n "$E2E_NAMESPACE" --ignore-not-found -kubectl delete service "${E2E_RELEASE}" -n "$E2E_NAMESPACE" --ignore-not-found -kubectl delete serviceaccount "${E2E_RELEASE}" -n "$E2E_NAMESPACE" --ignore-not-found - -echo "Cleaning up ConfigMap..." -kubectl delete configmap headlamp-kube-vip-plugin -n "$E2E_NAMESPACE" --ignore-not-found - -echo "Cleaning up test service account..." -kubectl delete serviceaccount headlamp-e2e-test -n "$E2E_NAMESPACE" --ignore-not-found - -if [ -f "$REPO_ROOT/.env.e2e" ]; then - rm "$REPO_ROOT/.env.e2e" - echo "Removed .env.e2e" -fi - -echo "" -echo "E2E teardown complete."