From ef4389aa05078377983076ff210a6657718d4bd7 Mon Sep 17 00:00:00 2001 From: "gandalf-the-greybeard[bot]" Date: Sat, 14 Mar 2026 22:53:39 +0000 Subject: [PATCH] fix: add react-router-dom devDep and remove unused vite types - Add react-router-dom as explicit devDependency to fix ServicesPage.test.tsx import resolution failure - Remove vite/client and vite-plugin-svgr/client from tsconfig types (not needed, aligns with polaris plugin pattern) Addresses QA review feedback on PR#11. --- package.json | 1 + tsconfig.json | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 68d9620..ecbb8b0 100644 --- a/package.json +++ b/package.json @@ -36,6 +36,7 @@ "jsdom": "^24.0.0", "react": "^18.3.1", "react-dom": "^18.3.1", + "react-router-dom": "^5.3.0", "vitest": "^3.0.5" } } diff --git a/tsconfig.json b/tsconfig.json index a00bcdf..841ee3b 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -2,7 +2,7 @@ "extends": "@kinvolk/headlamp-plugin/config/plugins-tsconfig.json", "compilerOptions": { "module": "esnext", - "types": ["vite/client", "vite-plugin-svgr/client", "vitest/globals", "@testing-library/jest-dom"] + "types": ["vitest/globals", "@testing-library/jest-dom"] }, "include": ["src"] }