fix: resolve bugs in ServicesPage, NodesPage, and k8s helpers

- Add missing useEffect dependency array and useCallback for closePanel
- Fix invalid StatusLabel status="" to "info" for non-kube-vip services
- Add ARIA dialog attributes to service detail panel
- Use phaseToStatus() in NodesPage instead of hardcoded Running check
- Remove dead code in getNodeVipLabel (label keys never contain =)
- Simplify redundant lease lookup in OverviewPage
- Fix 46 ESLint indentation warnings
- Add CHANGELOG.md

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

CHANGELOG.md

@@ -0,0 +1,40 @@
+# Changelog
+
+## [0.1.3] - 2026-03-04
+
+### Fixed
+
+- Fix missing `useEffect` dependency array on Escape key listener in ServicesPage (re-registered every render)
+- Wrap `closePanel` in `useCallback` to stabilize effect dependencies
+- Fix invalid empty string `StatusLabel` status for non-kube-vip services (now uses `"info"`)
+- Add ARIA `role="dialog"`, `aria-modal`, and `aria-label` to service detail slide-in panel
+- Replace invalid `aria-label` on backdrop div with `role="presentation"`
+- Use `phaseToStatus()` for pod status in NodesPage instead of hardcoded check (Failed pods now correctly show error)
+- Remove unreachable `startsWith('kube-vip.io/has-ip=')` branch in `getNodeVipLabel` (label keys never contain `=`)
+- Simplify redundant lease lookup conditions in OverviewPage
+- Fix 46 ESLint indentation warnings across all source files
+
+## [0.1.2] - 2025-05-20
+
+### Fixed
+
+- Add `--allow-same-version` flag for idempotent release retries
+- Use `action-gh-release` instead of `gh` CLI for release creation
+
+## [0.1.1] - 2025-05-20
+
+### Fixed
+
+- Remove redundant `mv` in release workflow
+- Move Node.js setup before `npm version` in release workflow
+
+## [0.1.0] - 2025-05-20
+
+### Added
+
+- Initial release
+- Overview dashboard with deployment status, VIP mode, leader election
+- LoadBalancer services page with VIP assignments and detail panel
+- Nodes page with kube-vip pod status and leader designation
+- Configuration page with DaemonSet config, IP pools, leases
+- Service detail section injected into native Headlamp Service views

src/api/k8s.ts

@@ -210,7 +210,6 @@ export function isControlPlaneNode(node: KubeVipNode): boolean {
 export function getNodeVipLabel(node: KubeVipNode): string | undefined {
   const labels = node.metadata.labels ?? {};
   for (const [key, value] of Object.entries(labels)) {
-    if (key.startsWith('kube-vip.io/has-ip=')) return value;
     if (key === 'kube-vip.io/has-ip') return value;
   }
   return undefined;

src/components/NodesPage.tsx

@@ -20,6 +20,7 @@ import {
   getNodeVipLabel,
   isControlPlaneNode,
   isNodeReady,
+  phaseToStatus,
 } from '../api/k8s';
 import { useKubeVipContext } from '../api/KubeVipDataContext';
 
@@ -83,7 +84,7 @@ export default function NodesPage() {
                   const pod = podByNode.get(n.metadata.name);
                   if (!pod) return '—';
                   return (
-                    <StatusLabel status={pod.status?.phase === 'Running' ? 'success' : 'warning'}>
+                    <StatusLabel status={phaseToStatus(pod.status?.phase)}>
                       {pod.status?.phase ?? 'Unknown'}
                     </StatusLabel>
                   );
@@ -127,7 +128,7 @@ export default function NodesPage() {
                   const pod = podByNode.get(n.metadata.name);
                   if (!pod) return '—';
                   return (
-                    <StatusLabel status={pod.status?.phase === 'Running' ? 'success' : 'warning'}>
+                    <StatusLabel status={phaseToStatus(pod.status?.phase)}>
                       {pod.status?.phase ?? 'Unknown'}
                     </StatusLabel>
                   );

src/components/OverviewPage.tsx

@@ -65,12 +65,8 @@ export default function OverviewPage() {
   const controlPlaneVIP = kubeVipConfig['address'] ?? '—';
 
   // Find leader from leases
-  const cpLease = leases.find(
+  const cpLease = leases.find(l => l.metadata.name.startsWith('plndr-cp-lock'));
-    l => l.metadata.name.startsWith('plndr-cp-lock') || l.metadata.name === 'plndr-cp-lock'
+  const svcLease = leases.find(l => l.metadata.name.startsWith('plndr-svcs-lock'));
-  );
-  const svcLease = leases.find(
-    l => l.metadata.name.startsWith('plndr-svcs-lock') || l.metadata.name === 'plndr-svcs-lock'
-  );
   const leaderNode = cpLease?.spec?.holderIdentity ?? svcLease?.spec?.holderIdentity ?? '—';
 
   return (

src/components/ServicesPage.test.tsx

@@ -76,7 +76,7 @@ describe('ServicesPage', () => {
     const svc = makeSampleService();
     mockContext({ loadBalancerServices: [svc] });
     render(<ServicesPage />);
-    fireEvent.click(screen.getByLabelText('Close panel backdrop'));
+    fireEvent.click(screen.getByTestId('panel-backdrop'));
     expect(mockPush).toHaveBeenCalledWith('/kube-vip/services');
   });
 

src/components/ServicesPage.tsx

@@ -13,7 +13,7 @@ import {
   SimpleTable,
   StatusLabel,
 } from '@kinvolk/headlamp-plugin/lib/CommonComponents';
-import React, { useEffect } from 'react';
+import React, { useCallback, useEffect } from 'react';
 import { useHistory, useLocation } from 'react-router-dom';
 import {
   formatAge,
@@ -38,7 +38,10 @@ export default function ServicesPage() {
     ? loadBalancerServices.find(s => `${s.metadata.namespace}/${s.metadata.name}` === selectedName)
     : null;
 
-  const closePanel = () => history.push(location.pathname);
+  const closePanel = useCallback(
+    () => history.push(location.pathname),
+    [history, location.pathname]
+  );
 
   useEffect(() => {
     if (!selectedName) return;
@@ -47,7 +50,7 @@ export default function ServicesPage() {
     };
     window.addEventListener('keydown', handler);
     return () => window.removeEventListener('keydown', handler);
-  });
+  }, [selectedName, closePanel]);
 
   if (loading) {
     return <Loader title="Loading services..." />;
@@ -111,7 +114,7 @@ export default function ServicesPage() {
             {
               label: 'kube-vip',
               getter: s => (
-                <StatusLabel status={isKubeVipService(s) ? 'success' : ''}>
+                <StatusLabel status={isKubeVipService(s) ? 'success' : 'info'}>
                   {isKubeVipService(s) ? 'Yes' : '—'}
                 </StatusLabel>
               ),
@@ -130,8 +133,9 @@ export default function ServicesPage() {
       {selectedService && (
         <>
           <div
+            role="presentation"
+            data-testid="panel-backdrop"
             onClick={closePanel}
-            aria-label="Close panel backdrop"
             style={{
               position: 'fixed',
               top: 0,
@@ -165,6 +169,9 @@ function ServiceDetailPanel({
 
   return (
     <div
+      role="dialog"
+      aria-modal="true"
+      aria-label="Service Details"
       style={{
         position: 'fixed',
         top: 0,