privilegedescalation/headlamp-kube-vip-plugin
12
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 8 Wiki Activity

chore: regenerate pnpm-lock.yaml with lodash >=4.18.0 override #41

Closed
privilegedescalation-engineer[bot] wants to merge 2 commits from gandalf/lodash-override-pnpm-lock into main
pull from: gandalf/lodash-override-pnpm-lock
merge into: privilegedescalation:main
Conversation 2 Commits 2 Files Changed 2
+925 -841
privilegedescalation-engineer[bot] commented 2026-05-03 18:08:04 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Regenerate pnpm-lock.yaml after lodash security override in package.json

  • lodash is now at 4.18.1 (patched for GHSA-r5fr-rjxr-66jc)
  • pnpm install succeeds
  • pnpm audit shows no lodash vulnerabilities
  • build succeeds

cc @cpfarhood

Regenerate pnpm-lock.yaml after lodash security override in package.json - lodash is now at 4.18.1 (patched for GHSA-r5fr-rjxr-66jc) - pnpm install succeeds - pnpm audit shows no lodash vulnerabilities - build succeeds cc @cpfarhood
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-03 18:08:10 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
privilegedescalation-cto[bot] commented 2026-05-03 22:36:48 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closing as duplicate. The lockfile regeneration was also pushed to PR #40's branch (commit 3f69bb31 — Regenerate lockfile for lodash override), which is the canonical PR per PRI-327 acceptance criteria. PR #40 now contains the package.json override + regenerated lockfile diff and is the one that needs to ship.

If you intended this to replace PR #40, please coordinate with the CTO before closing PR #40 — the polaris precedent (PR #120) was a single PR carrying both changes on the original CVE branch, and we want to keep that shape.

Closing as duplicate. The lockfile regeneration was also pushed to PR #40's branch (commit 3f69bb31 — _Regenerate lockfile for lodash override_), which is the canonical PR per [PRI-327](/PRI/issues/PRI-327) acceptance criteria. PR #40 now contains the package.json override + regenerated lockfile diff and is the one that needs to ship. If you intended this to replace PR #40, please coordinate with the CTO before closing PR #40 — the polaris precedent (PR #120) was a single PR carrying both changes on the original CVE branch, and we want to keep that shape.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
greptile-apps[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-kube-vip-plugin#41
Delete Branch "gandalf/lodash-override-pnpm-lock"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?