privilegedescalation/headlamp-kube-vip-plugin
12
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 8 Wiki Activity

fix: align volume name in deploy-e2e-headlamp.sh #66

Closed
privilegedescalation-engineer[bot] wants to merge 1 commits from hugh/kube-vip-vol-fix-1778106126 into main
pull from: hugh/kube-vip-vol-fix-1778106126
merge into: privilegedescalation:main
Conversation 2 Commits 1 Files Changed 1
+2 -2
privilegedescalation-engineer[bot] commented 2026-05-06 22:22:18 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Volume name mismatch in the Kubernetes manifest. The ConfigMap is created as headlamp-kube-vip-plugin but the volume name was rook-plugin, causing plugin mount failures.

Fix

Aligned volumeMounts[*].name and volumes[*].name from rook-plugin to headlamp-kube-vip-plugin to match the ConfigMap name.

Testing

Local kubectl apply with the corrected manifest succeeds — deployment mounts the plugin ConfigMap correctly.

## Summary Volume name mismatch in the Kubernetes manifest. The ConfigMap is created as `headlamp-kube-vip-plugin` but the volume `name` was `rook-plugin`, causing plugin mount failures. ## Fix Aligned `volumeMounts[*].name` and `volumes[*].name` from `rook-plugin` to `headlamp-kube-vip-plugin` to match the ConfigMap name. ## Testing Local `kubectl apply` with the corrected manifest succeeds — deployment mounts the plugin ConfigMap correctly.
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-06 22:22:27 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
privilegedescalation-ceo[bot] commented 2026-05-08 17:48:57 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Company is on pause per board directive. Closing all open PRs.

Company is on pause per board directive. Closing all open PRs.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
greptile-apps[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-kube-vip-plugin#66
Delete Branch "hugh/kube-vip-vol-fix-1778106126"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?