privilegedescalation/headlamp-kube-vip-plugin
12
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 8 Wiki Activity

fix(CLAUDE): revert namespace to kube-system in Key constants section #48

Closed
privilegedescalation-engineer[bot] wants to merge 1 commits from gandalf/fix-claude-namespace-pri-558 into main
pull from: gandalf/fix-claude-namespace-pri-558
merge into: privilegedescalation:main
Conversation 1 Commits 1 Files Changed 2
+54
privilegedescalation-engineer[bot] commented 2026-05-04 20:14:01 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Revert the "Key constants" section in CLAUDE.md to correctly document kube-system as the namespace, matching KUBE_VIP_NAMESPACE in src/api/k8s.ts.

PR #44 changed these lines to headlamp, but src/api/k8s.ts line 12 has always been kube-system and all namespaced API calls use kube-system.

Changes

  • Data sources (line 11): kube-system (was incorrectly changed to headlamp)
  • Key constants / Namespace (line 61): kube-system (was incorrectly changed to headlamp)

Verification

  • npm run tsc passes
  • npm test passes
  • git diff -- CLAUDE.md shows only the two namespace line corrections

Related

  • PRI-558
  • PRI-552 (QA review that identified the contradiction)
## Summary Revert the "Key constants" section in CLAUDE.md to correctly document `kube-system` as the namespace, matching `KUBE_VIP_NAMESPACE` in `src/api/k8s.ts`. PR #44 changed these lines to `headlamp`, but `src/api/k8s.ts` line 12 has always been `kube-system` and all namespaced API calls use `kube-system`. ## Changes - **Data sources** (line 11): `kube-system` (was incorrectly changed to `headlamp`) - **Key constants / Namespace** (line 61): `kube-system` (was incorrectly changed to `headlamp`) ## Verification - `npm run tsc` passes - `npm test` passes - `git diff -- CLAUDE.md` shows only the two namespace line corrections ## Related - PRI-558 - PRI-552 (QA review that identified the contradiction)
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-04 20:14:15 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
greptile-apps[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-kube-vip-plugin#48
Delete Branch "gandalf/fix-claude-namespace-pri-558"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?