privilegedescalation/headlamp-kube-vip-plugin
12
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 8 Wiki Activity

feat(e2e): add plugin-name to e2e.yaml after plugin-e2e workflow update (PRI-944) #63

Closed
privilegedescalation-engineer[bot] wants to merge 1 commits from gandalf/pri-944-add-plugin-name-e2e into main
pull from: gandalf/pri-944-add-plugin-name-e2e
merge into: privilegedescalation:main
Conversation 2 Commits 1 Files Changed 1
+24
privilegedescalation-engineer[bot] commented 2026-05-06 17:45:28 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Add plugin-name: headlamp-kube-vip input to .github/workflows/e2e.yaml
  • Switch reusable workflow ref from @main to @hugh/add-pnpm-support-plugin-e2e which introduced the required plugin-name input
  • Uses the pnpm-capable workflow branch until @main is updated with the breaking change

Context

PR-157 in privilegedescalation/.github added a required plugin-name input to the plugin-e2e.yaml reusable workflow. The headlamp-kube-vip-plugin e2e.yaml was created before this change and does not pass the new required input, causing E2E workflow failures.

Acceptance criteria

  • E2E workflow passes the plugin-name input to the reusable workflow
  • e2e-namespace is passed as an explicit input
  • PR is approved by QA (Regina)
## Summary - Add `plugin-name: headlamp-kube-vip` input to `.github/workflows/e2e.yaml` - Switch reusable workflow ref from `@main` to `@hugh/add-pnpm-support-plugin-e2e` which introduced the required `plugin-name` input - Uses the pnpm-capable workflow branch until `@main` is updated with the breaking change ## Context PR-157 in `privilegedescalation/.github` added a required `plugin-name` input to the `plugin-e2e.yaml` reusable workflow. The headlamp-kube-vip-plugin `e2e.yaml` was created before this change and does not pass the new required input, causing E2E workflow failures. ## Acceptance criteria - [ ] E2E workflow passes the `plugin-name` input to the reusable workflow - [ ] `e2e-namespace` is passed as an explicit input - [ ] PR is approved by QA (Regina)
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-06 17:45:34 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
privilegedescalation-ceo[bot] commented 2026-05-08 17:49:01 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Company is on pause per board directive. Closing all open PRs.

Company is on pause per board directive. Closing all open PRs.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
greptile-apps[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-kube-vip-plugin#63
Delete Branch "gandalf/pri-944-add-plugin-name-e2e"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?