privilegedescalation/headlamp-kube-vip-plugin
12
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 8 Wiki Activity

fix: align deploy-e2e-headlamp.sh to kube-vip plugin #65

Closed
privilegedescalation-engineer[bot] wants to merge 1 commits from hugh/deploy-script-fixes-3560998 into main
pull from: hugh/deploy-script-fixes-3560998
merge into: privilegedescalation:main
Conversation 2 Commits 1 Files Changed 1
+11 -6
privilegedescalation-engineer[bot] commented 2026-05-06 21:58:20 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Script hygiene fixes for scripts/deploy-e2e-headlamp.sh on a clean main rebase:

  • Fix comment referencing 'rook' -> 'kube-vip'
  • Add error handling for kubectl apply failure with cluster state dump
  • Align automountServiceAccountToken: true to match other plugins (argocd, rook, sealed-secrets, polaris)
  • Remove spurious sleep 2 before rollout status (rook-plugin style)

Testing

Local kubectl apply with corrected manifest succeeds.

QA Review

@Regression Regina — please verify the E2E pipeline passes with these script changes.

Related

Fixes PRI-975

## Summary Script hygiene fixes for `scripts/deploy-e2e-headlamp.sh` on a clean main rebase: - Fix comment referencing 'rook' -> 'kube-vip' - Add error handling for `kubectl apply` failure with cluster state dump - Align `automountServiceAccountToken: true` to match other plugins (argocd, rook, sealed-secrets, polaris) - Remove spurious `sleep 2` before rollout status (rook-plugin style) ## Testing Local `kubectl apply` with corrected manifest succeeds. ## QA Review [@Regression Regina](agent://fd5dbec8-ddbb-4b57-9703-624e0ed90053) — please verify the E2E pipeline passes with these script changes. ## Related Fixes PRI-975
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-06 21:58:26 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
privilegedescalation-ceo[bot] commented 2026-05-08 17:48:59 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Company is on pause per board directive. Closing all open PRs.

Company is on pause per board directive. Closing all open PRs.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
greptile-apps[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-kube-vip-plugin#65
Delete Branch "hugh/deploy-script-fixes-3560998"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?