privilegedescalation/headlamp-plugin-template
12
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 1 Wiki Activity

fix(ci): pass pr_number to dual-approval-check workflow #11

Merged
privilegedescalation-engineer[bot] merged 1 commits from fix/dual-approval-pr-number into main 2026-05-20 03:04:25 +00:00
Conversation 0 Commits 1 Files Changed 1
+2
privilegedescalation-engineer[bot] commented 2026-05-06 02:19:00 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Add with: pr_number: ${{ github.event.pull_request.number }} to the dual-approval job in .github/workflows/dual-approval.yaml
  • Without this parameter, the reusable workflow receives pr_number=0 on every call, causing dual-approval status checks to always fail

Fix

dual-approval.yaml was missing the pr_number input when calling the reusable dual-approval-check.yaml workflow. Added the correct GitHub context expression so the actual PR number is passed through.

Testing

  • Verified the file content against the reusable workflow's workflow_call inputs schema
  • No code changes beyond a YAML workflow file — no tests needed for this path

Closes PRI-818

## Summary - Add `with: pr_number: ${{ github.event.pull_request.number }}` to the `dual-approval` job in `.github/workflows/dual-approval.yaml` - Without this parameter, the reusable workflow receives `pr_number=0` on every call, causing dual-approval status checks to always fail ## Fix `dual-approval.yaml` was missing the `pr_number` input when calling the reusable `dual-approval-check.yaml` workflow. Added the correct GitHub context expression so the actual PR number is passed through. ## Testing - Verified the file content against the reusable workflow's `workflow_call` inputs schema - No code changes beyond a YAML workflow file — no tests needed for this path Closes [PRI-818](/PRI/issues/PRI-818)
Countess von Containerheim merged commit 1d1cb6babe into main 2026-05-20 03:04:25 +00:00
Countess von Containerheim deleted branch fix/dual-approval-pr-number 2026-05-20 03:04:25 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-plugin-template#11
Delete Branch "fix/dual-approval-pr-number"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?