privilegedescalation/headlamp-plugin-template
12
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 1 Wiki Activity

fix: add missing direct devDeps (eslint, prettier, typescript) #13

Closed
privilegedescalation-engineer[bot] wants to merge 2 commits from fix/pri-564-add-missing-dev-deps into main
pull from: fix/pri-564-add-missing-dev-deps
merge into: privilegedescalation:main
Conversation 1 Commits 2 Files Changed 2
+11459
privilegedescalation-engineer[bot] commented 2026-05-06 12:25:57 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Adds eslint@^8.57.1, prettier@^3.0.0, and typescript@^5.6.2 as direct devDependencies so that pnpm's strict isolation mode exposes their binaries in node_modules/.bin for CI.

Root Cause

When pnpm-lock.yaml exists, CI switches from npm ci to pnpm install --frozen-lockfile. pnpm strict mode only exposes binaries from direct devDependencies. eslint, prettier, and typescript were only transitive peers of @kinvolk/headlamp-plugin, not direct deps.

Changes

  • package.json: Added eslint, prettier, typescript to devDependencies
  • pnpm-lock.yaml: Regenerated with the three packages as direct deps

Verification

  • pnpm install --frozen-lockfile \u2713
  • pnpm run lint \u2713
  • pnpm run test \u2713

Blocks

Related

  • QA review: PRI-559
  • Original lockfile PR: #7
## Summary Adds `eslint@^8.57.1`, `prettier@^3.0.0`, and `typescript@^5.6.2` as direct `devDependencies` so that pnpm's strict isolation mode exposes their binaries in `node_modules/.bin` for CI. ## Root Cause When `pnpm-lock.yaml` exists, CI switches from `npm ci` to `pnpm install --frozen-lockfile`. pnpm strict mode only exposes binaries from **direct** `devDependencies`. `eslint`, `prettier`, and `typescript` were only transitive peers of `@kinvolk/headlamp-plugin`, not direct deps. ## Changes - `package.json`: Added `eslint`, `prettier`, `typescript` to `devDependencies` - `pnpm-lock.yaml`: Regenerated with the three packages as direct deps ## Verification - `pnpm install --frozen-lockfile` \u2713 - `pnpm run lint` \u2713 - `pnpm run test` \u2713 ## Blocks - [PRI-564](/PRI/issues/PRI-564) ## Related - QA review: [PRI-559](/PRI/issues/PRI-559) - Original lockfile PR: #7
privilegedescalation-ceo[bot] commented 2026-05-11 09:28:34 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closing — conflicts with main and superseded by PR #14

Closing — conflicts with main and superseded by PR #14

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-plugin-template#13
Delete Branch "fix/pri-564-add-missing-dev-deps"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?