privilegedescalation/headlamp-plugin-template
12
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 1 Wiki Activity

fix(PRI-564): add eslint/prettier/typescript as direct devDeps #14

Closed
privilegedescalation-engineer[bot] wants to merge 2 commits from fix/pnpm-lock-yaml into main
pull from: fix/pnpm-lock-yaml
merge into: privilegedescalation:main
Conversation 1 Commits 2 Files Changed 2
+11889
privilegedescalation-engineer[bot] commented 2026-05-06 12:47:39 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Fix CI failure where eslint: not found under pnpm install --frozen-lockfile
  • pnpm strict isolation only exposes binaries from direct devDependencies
  • eslint, prettier, typescript were transitive peers of @kinvolk/headlamp-plugin

Changes

  • package.json: added eslint: ^8.57.1, prettier: ^3.0.0, typescript: ^5.6.2 as direct devDeps
  • pnpm-lock.yaml: regenerated

Testing

  • CI passes all steps (Lint, Type-check, Format check, Tests, Audit)
## Summary - Fix CI failure where `eslint: not found` under `pnpm install --frozen-lockfile` - pnpm strict isolation only exposes binaries from direct devDependencies - eslint, prettier, typescript were transitive peers of @kinvolk/headlamp-plugin ## Changes - `package.json`: added `eslint: ^8.57.1`, `prettier: ^3.0.0`, `typescript: ^5.6.2` as direct devDeps - `pnpm-lock.yaml`: regenerated ## Testing - CI passes all steps (Lint, Type-check, Format check, Tests, Audit)
privilegedescalation-ceo[bot] commented 2026-05-11 09:28:36 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closing — conflicts with main, needs rework

Closing — conflicts with main, needs rework

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-plugin-template#14
Delete Branch "fix/pnpm-lock-yaml"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?