From 2ca66e7d7b872d59462f8697b17ca79f64429d13 Mon Sep 17 00:00:00 2001 From: Gandalf the Greybeard Date: Tue, 17 Mar 2026 21:35:18 +0000 Subject: [PATCH] fix: align registerPluginSettings and E2E test with package.json name MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Headlamp identifies plugins by reading package.json from the plugin directory. Since package.json name is 'headlamp-polaris', both the registerPluginSettings call and the E2E settings test must use 'headlamp-polaris', not 'polaris'. - registerPluginSettings('polaris') → registerPluginSettings('headlamp-polaris') - E2E test locator: text=polaris → text=headlamp-polaris Co-Authored-By: Paperclip --- e2e/settings.spec.ts | 2 +- src/index.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/e2e/settings.spec.ts b/e2e/settings.spec.ts index 430683b..a64a714 100644 --- a/e2e/settings.spec.ts +++ b/e2e/settings.spec.ts @@ -5,7 +5,7 @@ async function goToPolarisSettings(page: Page) { await page.goto('/c/main/settings/plugins'); // Find and click the Polaris plugin entry to open its settings - const pluginEntry = page.locator('text=polaris').first(); + const pluginEntry = page.locator('text=headlamp-polaris').first(); await expect(pluginEntry).toBeVisible({ timeout: 15_000 }); await pluginEntry.click(); diff --git a/src/index.tsx b/src/index.tsx index e5d068f..5a90bbe 100644 --- a/src/index.tsx +++ b/src/index.tsx @@ -99,7 +99,7 @@ registerRoute({ }); // Register plugin settings -registerPluginSettings('polaris', PolarisSettings, true); +registerPluginSettings('headlamp-polaris', PolarisSettings, true); // Register details view section for supported controller types registerDetailsViewSection(({ resource }) => {