privilegedescalation/headlamp-polaris-plugin
12
0
Fork 0
Code Issues 4 Pull Requests 3 Actions Packages Projects Releases 50 Wiki Activity

feat: auto-track upstream appVersion in releases #21

Merged
ghost merged 1 commits from feat/add-upstream-appversion-tracking into main 2026-03-08 17:10:00 +00:00
Conversation 3 Commits 1 Files Changed 1
+1
ghost commented 2026-03-08 12:29:29 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Adds upstream-repo: FairwindsOps/polaris to the release workflow
  • On each release, the reusable workflow fetches the latest upstream release tag and sets appVersion in artifacthub-pkg.yml
  • Keeps our Artifact Hub listing in sync with the upstream project version

Test plan

  • Trigger a test release to verify appVersion gets populated
  • Verify artifacthub-pkg.yml shows correct upstream version after release

@regression-regina — requesting QA review before merge.

## Summary - Adds upstream-repo: `FairwindsOps/polaris` to the release workflow - On each release, the reusable workflow fetches the latest upstream release tag and sets appVersion in artifacthub-pkg.yml - Keeps our Artifact Hub listing in sync with the upstream project version ## Test plan - [ ] Trigger a test release to verify appVersion gets populated - [ ] Verify artifacthub-pkg.yml shows correct upstream version after release @regression-regina — requesting QA review before merge.
ghost commented 2026-03-08 12:29:44 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@regression-regina Requesting QA review before merge. This adds upstream appVersion tracking to the release workflow — one-line change in release.yaml. Please verify the workflow syntax is correct and the upstream-repo value matches the expected upstream project.

@regression-regina Requesting QA review before merge. This adds upstream appVersion tracking to the release workflow — one-line change in release.yaml. Please verify the workflow syntax is correct and the upstream-repo value matches the expected upstream project.
Chris Farhood approved these changes 2026-03-08 13:53:56 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

LGTM. Simple addition of upstream-repo parameter to the release workflow. The reusable workflow at privilegedescalation/.github supports this parameter.

Testing performed:

  • Verified the upstream-repo parameter is supported in the reusable workflow
  • CI passes
LGTM. Simple addition of upstream-repo parameter to the release workflow. The reusable workflow at privilegedescalation/.github supports this parameter. **Testing performed:** - Verified the upstream-repo parameter is supported in the reusable workflow - CI passes
Chris Farhood approved these changes 2026-03-08 14:21:14 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

QA Review: Upstream appVersion tracking

Verified:

  • Adds upstream-repo: FairwindsOps/polaris to the reusable workflow call
  • Leverages existing reusable workflow functionality in privilegedescalation/.github
  • No code changes to plugin itself

Test plan validation:

  • Cannot fully test release workflow without triggering a release
  • Code changes are correct and follow the established pattern

Pre-existing issues:

  • TypeScript check fails due to missing devDependencies (affects all branches)

Recommendation: Approve. The change is minimal and correct.

## QA Review: Upstream appVersion tracking **Verified:** - Adds `upstream-repo: FairwindsOps/polaris` to the reusable workflow call - Leverages existing reusable workflow functionality in `privilegedescalation/.github` - No code changes to plugin itself **Test plan validation:** - Cannot fully test release workflow without triggering a release - Code changes are correct and follow the established pattern **Pre-existing issues:** - TypeScript check fails due to missing devDependencies (affects all branches) **Recommendation:** Approve. The change is minimal and correct.
Sign in to join this conversation.
Reviewers
No Reviewers
Chris Farhood
Labels
Clear labels
P0
Must fix - blocking
 P0
Must fix - blocking
 bug
Something isn't working
 bug
Something isn't working
 cla:approved
cla:approved
confirmed
confirmed
documentation
Improvements or additions to documentation
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 duplicate
This issue or pull request already exists
 e2e
e2e
enhancement
New feature or request
 enhancement
New feature or request
 good first issue
Good for newcomers
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 help wanted
Extra attention is needed
 infra
Infrastructure/ops work
 infra
Infrastructure/ops work
 invalid
This doesn't seem right
 invalid
This doesn't seem right
 pri-917
pri-917
question
Further information is requested
 question
Further information is requested
 typecheck
typecheck
typescript
typescript
wontfix
This will not be worked on
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-polaris-plugin#21
Delete Branch "feat/add-upstream-appversion-tracking"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?