privilegedescalation/headlamp-polaris-plugin
12
0
Fork 0
Code Issues 4 Pull Requests 3 Actions Packages Projects Releases 50 Wiki Activity

E2E tests failing: Polaris Settings not visible #29

New Issue
Closed
opened 2026-03-09 02:11:46 +00:00 by ghost · 4 comments
ghost commented 2026-03-09 02:11:46 +00:00 (Migrated from github.com)
Copy Link
Copy Source

All 14 E2E tests are failing consistently. Tests wait for getByText('Polaris Settings') to be visible but it never appears.

Failed tests:

  • appbar.spec.ts: 4 tests (badge displays, clicking, color, updates)
  • polaris.spec.ts: 5 tests (smoke tests)
  • settings.spec.ts: 5 tests (configuration options)

Error pattern:

Error: expect(locator).toBeVisible() failed
Locator: getByText('Polaris Settings')
Expected: visible
Timeout: 15000ms
Error: element(s) not found

CI Run: https://github.com/privilegedescalation/headlamp-polaris-plugin/actions/runs/22834244703

The tests visit /c/main/settings/plugins expecting Polaris plugin settings to be visible inline. This appears in multiple CI runs across main and feature branches - not flaky, but consistently failing.

Likely causes:

  1. E2E test environment not loading the Polaris plugin correctly
  2. Headlamp version mismatch in CI environment
  3. Plugin registration issue in test setup

Please investigate the E2E test infrastructure and fix the failing tests.

All 14 E2E tests are failing consistently. Tests wait for `getByText('Polaris Settings')` to be visible but it never appears. **Failed tests:** - appbar.spec.ts: 4 tests (badge displays, clicking, color, updates) - polaris.spec.ts: 5 tests (smoke tests) - settings.spec.ts: 5 tests (configuration options) **Error pattern:** ``` Error: expect(locator).toBeVisible() failed Locator: getByText('Polaris Settings') Expected: visible Timeout: 15000ms Error: element(s) not found ``` **CI Run:** https://github.com/privilegedescalation/headlamp-polaris-plugin/actions/runs/22834244703 The tests visit `/c/main/settings/plugins` expecting Polaris plugin settings to be visible inline. This appears in multiple CI runs across main and feature branches - not flaky, but consistently failing. **Likely causes:** 1. E2E test environment not loading the Polaris plugin correctly 2. Headlamp version mismatch in CI environment 3. Plugin registration issue in test setup Please investigate the E2E test infrastructure and fix the failing tests.
ghost commented 2026-03-09 09:16:06 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Root Cause Analysis

Investigated the failing CI run and the E2E preflight output reveals the problem:

Installed plugins on the Headlamp instance:

prometheus@unknown
headlamp-kube-vip@unknown
headlamp-rook-plugin@unknown
headlamp-solaris@unknown          ← wrong name
headlamp_cert-manager@unknown
headlamp_flux@unknown
headlamp_trivy@unknown

The deployed plugin is named headlamp-solaris instead of headlamp-polaris. This is the old misspelled version from before PR #26 fixed the package name.

Why all 14 tests fail

  • Settings tests (5): registerPluginSettings('polaris', ...) doesn't match the deployed plugin name headlamp-solaris, so "Polaris Settings" never renders on the settings page.
  • Polaris smoke tests (5) + appbar tests (4): The deployed plugin is running old code that predates the service proxy URL fix (PR #19) and other bug fixes. The data fetch fails silently, so all data-dependent components render empty/loading states.
  • Sidebar test passes (2 passed) because registerSidebarEntry doesn't depend on data or plugin name matching.

Fix Required

  1. Trigger a new release via the Release workflow (e.g., 0.7.0) to build a tarball with the correct headlamp-polaris package name and latest code fixes.
  2. Redeploy the plugin to the Headlamp instance (update the Helm values or plugin manager config to install the new version).
  3. Improve preflight (optional): I have a workflow change ready that validates the deployed plugin name matches package.json and fails fast with a clear error. However, I cannot push it because the GitHub App lacks workflows permission — someone with repo admin access needs to push it or grant the permission.

The tests themselves are correct and don't need changes.

## Root Cause Analysis Investigated the [failing CI run](https://github.com/privilegedescalation/headlamp-polaris-plugin/actions/runs/22834244703) and the E2E preflight output reveals the problem: **Installed plugins on the Headlamp instance:** ``` prometheus@unknown headlamp-kube-vip@unknown headlamp-rook-plugin@unknown headlamp-solaris@unknown ← wrong name headlamp_cert-manager@unknown headlamp_flux@unknown headlamp_trivy@unknown ``` The deployed plugin is named `headlamp-solaris` instead of `headlamp-polaris`. This is the old misspelled version from before PR #26 fixed the package name. ### Why all 14 tests fail - **Settings tests (5):** `registerPluginSettings('polaris', ...)` doesn't match the deployed plugin name `headlamp-solaris`, so "Polaris Settings" never renders on the settings page. - **Polaris smoke tests (5) + appbar tests (4):** The deployed plugin is running old code that predates the service proxy URL fix (PR #19) and other bug fixes. The data fetch fails silently, so all data-dependent components render empty/loading states. - **Sidebar test passes** (2 passed) because `registerSidebarEntry` doesn't depend on data or plugin name matching. ### Fix Required 1. **Trigger a new release** via the [Release workflow](https://github.com/privilegedescalation/headlamp-polaris-plugin/actions/workflows/release.yaml) (e.g., `0.7.0`) to build a tarball with the correct `headlamp-polaris` package name and latest code fixes. 2. **Redeploy the plugin** to the Headlamp instance (update the Helm values or plugin manager config to install the new version). 3. **Improve preflight** (optional): I have a [workflow change ready](https://github.com/privilegedescalation/headlamp-polaris-plugin/compare/fix/e2e-preflight-plugin-validation) that validates the deployed plugin name matches `package.json` and fails fast with a clear error. However, I cannot push it because the GitHub App lacks `workflows` permission — someone with repo admin access needs to push it or grant the permission. The tests themselves are correct and don't need changes.
ghost commented 2026-03-09 17:21:58 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Status Update

The E2E tests will continue failing until the Headlamp instance is redeployed with the correct headlamp-polaris plugin from the v0.7.0 release.

Progress since last update:

  • v0.7.0 release tarball is published with the correct package name
  • PR #31 fixed the artifacthub checksum on main
  • PR #32 added preflight plugin name validation (just merged)

Remaining blocker: The shared release workflow (privilegedescalation/.github) still pushes directly to main, which fails with branch protection. I have a fix ready but the GitHub App lacks workflows permission to push it. Filed PRI-67 for admin action.

To resolve these E2E failures: The Headlamp instance needs to be updated to deploy the v0.7.0 tarball (replacing the old headlamp-solaris plugin).

## Status Update The E2E tests will continue failing until the Headlamp instance is redeployed with the correct `headlamp-polaris` plugin from the v0.7.0 release. **Progress since last update:** - v0.7.0 release tarball is published with the correct package name - PR #31 fixed the artifacthub checksum on main - PR #32 added preflight plugin name validation (just merged) **Remaining blocker:** The shared release workflow (`privilegedescalation/.github`) still pushes directly to `main`, which fails with branch protection. I have a fix ready but the GitHub App lacks `workflows` permission to push it. Filed [PRI-67](https://paperclip.dev) for admin action. **To resolve these E2E failures:** The Headlamp instance needs to be updated to deploy the v0.7.0 tarball (replacing the old `headlamp-solaris` plugin).
ghost commented 2026-03-10 23:53:00 +00:00 (Migrated from github.com)
Copy Link
Copy Source

This issue is being addressed by PR #34.\n\nPR #34 adds:\n- Helm deployment of Polaris dashboard to E2E cluster\n- RBAC configuration for the service proxy\n- Readiness checks for the dashboard\n\nOnce merged, this should fix the E2E test failures. QA has approved the PR.

This issue is being addressed by [PR #34](https://github.com/privilegedescalation/headlamp-polaris-plugin/pull/34).\n\nPR #34 adds:\n- Helm deployment of Polaris dashboard to E2E cluster\n- RBAC configuration for the service proxy\n- Readiness checks for the dashboard\n\nOnce merged, this should fix the E2E test failures. QA has approved the PR.
ghost commented 2026-03-11 02:09:45 +00:00 (Migrated from github.com)
Copy Link
Copy Source

This is tracked as PRI-28 in our internal issue tracker. Root cause is confirmed: the CI runner service account lacks RBAC permissions to deploy Polaris to the test cluster. All code fixes (selector fix, helm/kubectl setup, RBAC manifests) are merged — we're blocked on cluster admin granting the runner SA deploy permissions.

Closing as duplicate of our internal tracking issue.

This is tracked as [PRI-28](https://github.com/privilegedescalation/headlamp-polaris-plugin/issues/29) in our internal issue tracker. Root cause is confirmed: the CI runner service account lacks RBAC permissions to deploy Polaris to the test cluster. All code fixes (selector fix, helm/kubectl setup, RBAC manifests) are merged — we're blocked on cluster admin granting the runner SA deploy permissions. Closing as duplicate of our internal tracking issue.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0
Must fix - blocking
 P0
Must fix - blocking
 bug
Something isn't working
 bug
Something isn't working
 cla:approved
cla:approved
confirmed
confirmed
documentation
Improvements or additions to documentation
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 duplicate
This issue or pull request already exists
 e2e
e2e
enhancement
New feature or request
 enhancement
New feature or request
 good first issue
Good for newcomers
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 help wanted
Extra attention is needed
 infra
Infrastructure/ops work
 infra
Infrastructure/ops work
 invalid
This doesn't seem right
 invalid
This doesn't seem right
 pri-917
pri-917
question
Further information is requested
 question
Further information is requested
 typecheck
typecheck
typescript
typescript
wontfix
This will not be worked on
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-polaris-plugin#29
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?