privilegedescalation/headlamp-polaris-plugin
12
0
Fork 0
Code Issues 4 Pull Requests 3 Actions Packages Projects Releases 50 Wiki Activity

TypeScript check fails: missing type definitions #36

New Issue
Closed
opened 2026-03-11 09:58:06 +00:00 by ghost · 0 comments
ghost commented 2026-03-11 09:58:06 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Description

Running npm run tsc fails with the following error:

error TS2688: Cannot find type definition file for 'vite-plugin-svgr/client'.
error TS2688: Cannot find type definition file for 'vite/client'.

Root Cause

The tsconfig.json references type definitions that are not installed in devDependencies:

  • vite/client
  • vite-plugin-svgr/client

These are listed in compilerOptions.types but the packages @types/vite and vite-plugin-svgr are not in package.json.

Reproduction

cd headlamp-polaris-plugin
npm install
npm run tsc

Expected

TypeScript check should pass (as documented in CLAUDE.md: "All tests and tsc must pass before committing").

Suggested Fix

Either:

  1. Add missing type packages to devDependencies, OR
  2. Remove the unused type references from tsconfig.json

Tests: pass (77/77)
Lint: passes
TypeScript: FAILS

## Description Running `npm run tsc` fails with the following error: ``` error TS2688: Cannot find type definition file for 'vite-plugin-svgr/client'. error TS2688: Cannot find type definition file for 'vite/client'. ``` ## Root Cause The `tsconfig.json` references type definitions that are not installed in devDependencies: - `vite/client` - `vite-plugin-svgr/client` These are listed in `compilerOptions.types` but the packages `@types/vite` and `vite-plugin-svgr` are not in `package.json`. ## Reproduction ```bash cd headlamp-polaris-plugin npm install npm run tsc ``` ## Expected TypeScript check should pass (as documented in CLAUDE.md: "All tests and tsc must pass before committing"). ## Suggested Fix Either: 1. Add missing type packages to devDependencies, OR 2. Remove the unused type references from tsconfig.json Tests: pass (77/77) Lint: passes TypeScript: FAILS
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0
Must fix - blocking
 P0
Must fix - blocking
 bug
Something isn't working
 bug
Something isn't working
 cla:approved
cla:approved
confirmed
confirmed
documentation
Improvements or additions to documentation
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 duplicate
This issue or pull request already exists
 e2e
e2e
enhancement
New feature or request
 enhancement
New feature or request
 good first issue
Good for newcomers
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 help wanted
Extra attention is needed
 infra
Infrastructure/ops work
 infra
Infrastructure/ops work
 invalid
This doesn't seem right
 invalid
This doesn't seem right
 pri-917
pri-917
question
Further information is requested
 question
Further information is requested
 typecheck
typecheck
typescript
typescript
wontfix
This will not be worked on
 wontfix
This will not be worked on
No Label bug confirmed typecheck
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-polaris-plugin#36
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?