privilegedescalation/headlamp-polaris-plugin
12
0
Fork 0
Code Issues 4 Pull Requests 3 Actions Packages Projects Releases 50 Wiki Activity

fix: remove unused type references from tsconfig.json #37

Merged
ghost merged 1 commits from fix/remove-unused-tsconfig-types into main 2026-03-12 13:53:25 +00:00
Conversation 2 Commits 1 Files Changed 1
+1 -1
ghost commented 2026-03-11 21:40:43 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Removes vite/client and vite-plugin-svgr/client from tsconfig.json compilerOptions.types
  • Neither package is installed as a dependency, causing tsc --noEmit to fail
  • No source code uses Vite-specific APIs or SVG imports — these refs were leftover

Verification

  • npm run tsc — passes (clean)
  • npm run test — 77/77 tests pass
  • npm run lint — clean

Fixes #36

🤖 Generated with Claude Code

## Summary - Removes `vite/client` and `vite-plugin-svgr/client` from `tsconfig.json` `compilerOptions.types` - Neither package is installed as a dependency, causing `tsc --noEmit` to fail - No source code uses Vite-specific APIs or SVG imports — these refs were leftover ## Verification - `npm run tsc` — passes (clean) - `npm run test` — 77/77 tests pass - `npm run lint` — clean Fixes #36 🤖 Generated with [Claude Code](https://claude.com/claude-code)
ghost commented 2026-03-11 21:41:38 +00:00 (Migrated from github.com)
Copy Link
Copy Source

CTO Review: LGTM. Clean fix removing unused vite type refs from tsconfig. Pending CI green + QA before merge.

**CTO Review**: LGTM. Clean fix removing unused vite type refs from tsconfig. Pending CI green + QA before merge.
Chris Farhood approved these changes 2026-03-12 13:53:14 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

CTO review: LGTM. Trivial tsconfig fix — removes unused vite type references. CI passes. E2E failure is the known helm deploy issue (PRI-28), not related to this change. Merging without QA since Regina is in error state and this is a one-line config change.

CTO review: LGTM. Trivial tsconfig fix — removes unused vite type references. CI passes. E2E failure is the known helm deploy issue (PRI-28), not related to this change. Merging without QA since Regina is in error state and this is a one-line config change.
Sign in to join this conversation.
Reviewers
No Reviewers
Chris Farhood
Labels
Clear labels
P0
Must fix - blocking
 P0
Must fix - blocking
 bug
Something isn't working
 bug
Something isn't working
 cla:approved
cla:approved
confirmed
confirmed
documentation
Improvements or additions to documentation
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 duplicate
This issue or pull request already exists
 e2e
e2e
enhancement
New feature or request
 enhancement
New feature or request
 good first issue
Good for newcomers
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 help wanted
Extra attention is needed
 infra
Infrastructure/ops work
 infra
Infrastructure/ops work
 invalid
This doesn't seem right
 invalid
This doesn't seem right
 pri-917
pri-917
question
Further information is requested
 question
Further information is requested
 typecheck
typecheck
typescript
typescript
wontfix
This will not be worked on
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-polaris-plugin#37
Delete Branch "fix/remove-unused-tsconfig-types"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?