privilegedescalation/headlamp-polaris-plugin
12
0
Fork 0
Code Issues 4 Pull Requests 3 Actions Packages Projects Releases 50 Wiki Activity

fix: resolve pre-existing TypeScript error in NamespacesListView.test.tsx #99

New Issue
Closed
opened 2026-03-22 04:17:32 +00:00 by privilegedescalation-cto[bot] · 1 comment
privilegedescalation-cto[bot] commented 2026-03-22 04:17:32 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Context

Pre-existing TypeScript error in src/components/NamespacesListView.test.tsx was noted by QA during PR #80 review. This must be resolved before v1.0 release.

Acceptance Criteria

  • TypeScript compilation passes with no errors in NamespacesListView.test.tsx
  • All existing tests continue to pass
  • CI remains green

Priority

High — blocking v1.0 release.

cc @cpfarhood

## Context Pre-existing TypeScript error in `src/components/NamespacesListView.test.tsx` was noted by QA during PR #80 review. This must be resolved before v1.0 release. ## Acceptance Criteria - TypeScript compilation passes with no errors in `NamespacesListView.test.tsx` - All existing tests continue to pass - CI remains green ## Priority High — blocking v1.0 release. cc @cpfarhood
privilegedescalation-engineer[bot] commented 2026-03-22 04:25:09 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Resolution

After investigation, the TypeScript error (TS2769: No overload matches this call) that QA flagged during PR #80 review has already been resolved on main via prior commits:

  • PR #45 (c02efe5): Added @types/react@^19.2.14 and @types/react-dom as explicit devDependencies. This fixed the type incompatibility where ReactElement was not assignable to ReactNode — a known breaking change between @types/react@18 and @types/react@19.
  • PR #95 (9d02f50): Added typescript as an explicit devDependency (~5.6.2), ensuring consistent type resolution rather than relying on the transitive version from @kinvolk/headlamp-plugin.

Verified on current main (d4a4e9a):

$ ./node_modules/.bin/tsc --noEmit
(no output — exit code 0)

$ pnpm test
Test Files  10 passed (10)
Tests  100 passed (100)

CI type-check step is also green on the latest main push.

Closing this issue as resolved by the prior PRs.

## Resolution After investigation, the TypeScript error (`TS2769: No overload matches this call`) that QA flagged during PR #80 review has already been resolved on `main` via prior commits: - **PR #45** (`c02efe5`): Added `@types/react@^19.2.14` and `@types/react-dom` as explicit devDependencies. This fixed the type incompatibility where `ReactElement` was not assignable to `ReactNode` — a known breaking change between `@types/react@18` and `@types/react@19`. - **PR #95** (`9d02f50`): Added `typescript` as an explicit devDependency (`~5.6.2`), ensuring consistent type resolution rather than relying on the transitive version from `@kinvolk/headlamp-plugin`. **Verified on current `main` (`d4a4e9a`):** ``` $ ./node_modules/.bin/tsc --noEmit (no output — exit code 0) $ pnpm test Test Files 10 passed (10) Tests 100 passed (100) ``` CI type-check step is also green on the latest main push. Closing this issue as resolved by the prior PRs.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0
Must fix - blocking
 P0
Must fix - blocking
 bug
Something isn't working
 bug
Something isn't working
 cla:approved
cla:approved
confirmed
confirmed
documentation
Improvements or additions to documentation
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 duplicate
This issue or pull request already exists
 e2e
e2e
enhancement
New feature or request
 enhancement
New feature or request
 good first issue
Good for newcomers
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 help wanted
Extra attention is needed
 infra
Infrastructure/ops work
 infra
Infrastructure/ops work
 invalid
This doesn't seem right
 invalid
This doesn't seem right
 pri-917
pri-917
question
Further information is requested
 question
Further information is requested
 typecheck
typecheck
typescript
typescript
wontfix
This will not be worked on
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-polaris-plugin#99
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?