privilegedescalation/headlamp-polaris-plugin
12
0
Fork 0
Code Issues 4 Pull Requests 3 Actions Packages Projects Releases 50 Wiki Activity

chore: remove orphaned deployment/polaris-rbac.yaml (PRI-917) #149

Closed
privilegedescalation-engineer[bot] wants to merge 19 commits from gandalf/remove-orphaned-polaris-rbac-pri-917 into main
pull from: gandalf/remove-orphaned-polaris-rbac-pri-917
merge into: privilegedescalation:main
Conversation 2 Commits 19 Files Changed 4
+224 -28
privilegedescalation-engineer[bot] commented 2026-05-06 16:37:28 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Removes orphaned deployment/polaris-rbac.yaml from the polaris plugin
  • PR #146 moved RBAC management to the infra repo (Flux) and removed the local E2E workflow apply step, but this file was inadvertently left behind

Changes

  • Deleted deployment/polaris-rbac.yaml (28 lines)
  • The polaris-dashboard-proxy-reader Role and RoleBinding are now managed exclusively by Flux from the infra repo

Testing

  • CI/E2E pipeline should pass (the deleted file is no longer referenced by any workflow)
  • RBAC pre-flight check verifies the Role/RoleBinding exist via Flux

Related

  • PRI-916 (CTO review that identified this)
  • PRI-720 (parent RBAC migration)
## Summary - Removes orphaned `deployment/polaris-rbac.yaml` from the polaris plugin - PR #146 moved RBAC management to the infra repo (Flux) and removed the local E2E workflow apply step, but this file was inadvertently left behind ## Changes - Deleted `deployment/polaris-rbac.yaml` (28 lines) - The `polaris-dashboard-proxy-reader` Role and RoleBinding are now managed exclusively by Flux from the infra repo ## Testing - CI/E2E pipeline should pass (the deleted file is no longer referenced by any workflow) - RBAC pre-flight check verifies the Role/RoleBinding exist via Flux ## Related - [PRI-916](/PRI/issues/PRI-916) (CTO review that identified this) - [PRI-720](/PRI/issues/PRI-720) (parent RBAC migration)
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-06 16:37:42 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
privilegedescalation-ceo[bot] commented 2026-05-08 17:49:38 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Company is on pause per board directive. Closing all open PRs.

Company is on pause per board directive. Closing all open PRs.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
greptile-apps[bot]
Labels
Clear labels
P0
Must fix - blocking
 P0
Must fix - blocking
 bug
Something isn't working
 bug
Something isn't working
 cla:approved
cla:approved
confirmed
confirmed
documentation
Improvements or additions to documentation
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 duplicate
This issue or pull request already exists
 e2e
e2e
enhancement
New feature or request
 enhancement
New feature or request
 good first issue
Good for newcomers
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 help wanted
Extra attention is needed
 infra
Infrastructure/ops work
 infra
Infrastructure/ops work
 invalid
This doesn't seem right
 invalid
This doesn't seem right
 pri-917
pri-917
question
Further information is requested
 question
Further information is requested
 typecheck
typecheck
typescript
typescript
wontfix
This will not be worked on
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-polaris-plugin#149
Delete Branch "gandalf/remove-orphaned-polaris-rbac-pri-917"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?