feat: add ExemptionManager tests, coverage threshold, and ArtifactHub metadata polish #82

Merged
privilegedescalation-engineer[bot] merged 5 commits from feat/exemption-manager-tests into main 2026-03-21 12:53:08 +00:00
6 changed files with 15 additions and 59 deletions
Showing only changes of commit 08a3009ba8 - Show all commits
+1 -1
View File
@@ -11,7 +11,7 @@ permissions:
contents: read
env:
E2E_NAMESPACE: headlamp-e2e
E2E_NAMESPACE: default
E2E_RELEASE: headlamp-e2e
jobs:
+5 -32
View File
@@ -2,20 +2,19 @@
# RBAC for the GitHub Actions CI runner to manage the E2E Headlamp instance.
# CI-only test fixture — NOT for production use.
#
# Grants the ARC runner service account permissions in the headlamp-e2e
# namespace to deploy and tear down a dedicated Headlamp instance via Helm.
# Grants the ARC runner service account permissions in the default namespace
# to deploy and tear down a dedicated Headlamp instance via Helm.
# E2E resources run in `default` — nothing persists beyond a test run.
#
# No kube-system access needed — E2E tests use a separate namespace.
# Plugin is loaded via ConfigMap volume mount — no custom Docker images.
#
# Prerequisites:
# kubectl create namespace headlamp-e2e
# kubectl apply -f deployment/e2e-ci-runner-rbac.yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
name: e2e-ci-runner
namespace: headlamp-e2e
namespace: default
rules:
# Helm needs to manage these resources for the Headlamp chart
- apiGroups: ["apps"]
@@ -36,7 +35,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
name: e2e-ci-runner-binding
namespace: headlamp-e2e
namespace: default
subjects:
- kind: ServiceAccount
name: runners-privilegedescalation-gha-rs-no-permission
@@ -45,29 +44,3 @@ roleRef:
kind: Role
name: e2e-ci-runner
apiGroup: rbac.authorization.k8s.io
---
# ClusterRole to allow the runner SA to verify the headlamp-e2e namespace
# exists before attempting namespaced operations. kubectl get namespace is a
# cluster-scoped operation not coverable by a namespaced Role.
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: e2e-ci-namespace-reader
rules:
- apiGroups: [""]
resources: ["namespaces"]
verbs: ["get"]
resourceNames: ["headlamp-e2e"]
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: e2e-ci-namespace-reader-binding
subjects:
- kind: ServiceAccount
name: runners-privilegedescalation-gha-rs-no-permission
namespace: arc-runners
roleRef:
kind: ClusterRole
name: e2e-ci-namespace-reader
apiGroup: rbac.authorization.k8s.io
+1 -1
View File
@@ -7,7 +7,7 @@
#
# Usage:
# helm install headlamp-e2e headlamp/headlamp \
# -n headlamp-e2e --create-namespace \
# -n default \
# -f deployment/headlamp-e2e-values.yaml \
# --set image.registry=ghcr.io \
# --set image.repository=headlamp-k8s/headlamp \
-1
View File
@@ -275,7 +275,6 @@ No custom Docker images, no PVCs, no kubectl exec/cp, no patching of existing de
One-time setup by a cluster admin:
```bash
kubectl create namespace headlamp-e2e
kubectl apply -f deployment/e2e-ci-runner-rbac.yaml
```
+6 -13
View File
@@ -5,14 +5,17 @@
# a ConfigMap volume mount. No custom Docker images — the plugin is built
# in CI and injected as a ConfigMap.
#
# E2E resources are deployed to the `default` namespace. Nothing persists
# beyond the test run — teardown cleans up all created resources.
#
# Prerequisites:
# - Plugin built (dist/ exists with plugin-main.js + package.json)
# - kubectl configured with cluster access
# - Helm 3 installed
# - E2E namespace pre-created by cluster admin (see deployment/e2e-ci-runner-rbac.yaml)
# - RBAC applied: kubectl apply -f deployment/e2e-ci-runner-rbac.yaml
#
# Environment:
# E2E_NAMESPACE — namespace for E2E Headlamp (default: headlamp-e2e)
# E2E_NAMESPACE — namespace for E2E Headlamp (default: default)
# E2E_RELEASE — Helm release name (default: headlamp-e2e)
# HEADLAMP_VERSION — Headlamp image tag (default: latest)
set -euo pipefail
@@ -20,7 +23,7 @@ set -euo pipefail
REPO_ROOT="$(cd "$(dirname "$0")/.." && pwd)"
DIST_DIR="$REPO_ROOT/dist"
E2E_NAMESPACE="${E2E_NAMESPACE:-headlamp-e2e}"
E2E_NAMESPACE="${E2E_NAMESPACE:-default}"
E2E_RELEASE="${E2E_RELEASE:-headlamp-e2e}"
HEADLAMP_VERSION="${HEADLAMP_VERSION:-latest}"
@@ -34,16 +37,6 @@ echo " Image: ghcr.io/headlamp-k8s/headlamp:${HEADLAMP_VERSION}"
echo " Namespace: $E2E_NAMESPACE"
echo " Release: $E2E_RELEASE"
# --- Verify namespace exists (must be pre-created by cluster admin) ---
echo ""
echo "Verifying namespace ${E2E_NAMESPACE} exists..."
if ! kubectl get namespace "$E2E_NAMESPACE" >/dev/null 2>&1; then
echo "ERROR: Namespace ${E2E_NAMESPACE} does not exist." >&2
echo "A cluster admin must create it first: kubectl create namespace ${E2E_NAMESPACE}" >&2
echo "Then apply RBAC: kubectl apply -f deployment/e2e-ci-runner-rbac.yaml" >&2
exit 1
fi
# --- Create ConfigMap from built plugin ---
echo ""
echo "Creating ConfigMap with plugin files..."
+2 -11
View File
@@ -4,21 +4,15 @@
# Tears down the dedicated E2E Headlamp instance deployed by deploy-e2e-headlamp.sh.
#
# Environment:
# E2E_NAMESPACE — namespace to clean up (default: headlamp-e2e)
# E2E_NAMESPACE — namespace to clean up (default: default)
# E2E_RELEASE — Helm release to uninstall (default: headlamp-e2e)
set -euo pipefail
REPO_ROOT="$(cd "$(dirname "$0")/.." && pwd)"
E2E_NAMESPACE="${E2E_NAMESPACE:-headlamp-e2e}"
E2E_NAMESPACE="${E2E_NAMESPACE:-default}"
E2E_RELEASE="${E2E_RELEASE:-headlamp-e2e}"
# Exit early if the namespace does not exist — nothing to tear down.
if ! kubectl get namespace "$E2E_NAMESPACE" >/dev/null 2>&1; then
echo "Namespace $E2E_NAMESPACE does not exist, nothing to tear down."
exit 0
fi
echo "=== E2E Headlamp Teardown ==="
echo " Namespace: $E2E_NAMESPACE"
echo " Release: $E2E_RELEASE"
@@ -32,9 +26,6 @@ kubectl delete configmap headlamp-polaris-plugin -n "$E2E_NAMESPACE" --ignore-no
echo "Cleaning up service account..."
kubectl delete serviceaccount headlamp-e2e-test -n "$E2E_NAMESPACE" --ignore-not-found
# Note: namespace is NOT deleted — it is managed by a cluster admin.
# The runner SA only has namespace-scoped permissions (see deployment/e2e-ci-runner-rbac.yaml).
# Clean up local env file
rm -f "$REPO_ROOT/.env.e2e"