From 13347ab9c18c3d30935cd92e7433f4fc31010a65 Mon Sep 17 00:00:00 2001
From: Chris Farhood <chris@farhood.org>
Date: Tue, 5 May 2026 14:02:34 +0000
Subject: [PATCH] fix(e2e): prevent stale sidebar reference in storage-classes
 navigation test

Re-acquire sidebar reference after clicking Rook button to avoid
stale locator capturing wrong sidebar state during transition.

PR #56 follow-up for PRI-699.
---
 e2e/rook.spec.ts | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/e2e/rook.spec.ts b/e2e/rook.spec.ts
index 1b3d556..7f77477 100644
--- a/e2e/rook.spec.ts
+++ b/e2e/rook.spec.ts
@@ -45,11 +45,15 @@ test.describe('Rook plugin smoke tests', () => {
     const sidebar = page.getByRole('navigation', { name: 'Navigation' });
 
     const rookBtn = sidebar.getByRole('button', { name: /rook/i });
+    await expect(rookBtn).toBeVisible();
     await rookBtn.click();
     await page.waitForLoadState('networkidle');
 
-    const storageClassesLink = sidebar.getByRole('link', { name: /storage classes/i });
-    await expect(storageClassesLink).toBeVisible({ timeout: 10_000 });
+    const sidebarAfterClick = page.getByRole('navigation', { name: 'Navigation' });
+    await expect(sidebarAfterClick).toBeVisible();
+
+    const storageClassesLink = sidebarAfterClick.getByRole('link', { name: /storage classes/i });
+    await storageClassesLink.waitFor({ state: 'visible', timeout: 15_000 });
     await storageClassesLink.click();
 
     await page.waitForLoadState('networkidle');