privilegedescalation/headlamp-rook-plugin
Archived
12
0
Fork 0
Code Issues 8 Pull Requests 1 Actions Packages Projects Releases 14 Wiki Activity

fix(e2e): add waitForSidebar helper and networkidle waits for reliability

Browse Source 
Add waitForSidebar helper function with explicit sidebar visibility wait
and networkidle state to ensure page is fully loaded before assertions.
This addresses flaky E2E tests where elements were not consistently
found due to timing issues during page transitions.
This commit is contained in:
Chris Farhood
2026-05-05 06:50:21 +00:00
committed by Gandalf the Greybeard [agent]
parent b6941756f7
commit 8d2ec06e41
1 changed files with 15 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e/rook.spec.ts
+15 -6
View File
@@ -1,28 +1,35 @@
import { test, expect } from '@playwright/test'; import { test, expect } from '@playwright/test';
async function waitForSidebar(page: import('@playwright/test').Page) {
const sidebar = page.getByRole('navigation', { name: 'Navigation' });
await expect(sidebar).toBeVisible({ timeout: 15_000 });
await page.waitForLoadState('networkidle');
return sidebar;
}
test.describe('Rook plugin smoke tests', () => { test.describe('Rook plugin smoke tests', () => {
test('sidebar contains Rook entry', async ({ page }) => { test('sidebar contains Rook entry', async ({ page }) => {
await page.goto('/'); await page.goto('/');
const sidebar = page.getByRole('navigation', { name: 'Navigation' }); const sidebar = await waitForSidebar(page);
await expect(sidebar).toBeVisible({ timeout: 15_000 });
await expect(sidebar.getByRole('button', { name: /rook/i })).toBeVisible(); await expect(sidebar.getByRole('button', { name: /rook/i })).toBeVisible();
}); });
test('Rook sidebar entry navigates to overview', async ({ page }) => { test('Rook sidebar entry navigates to overview', async ({ page }) => {
await page.goto('/'); await page.goto('/');
const sidebar = page.getByRole('navigation', { name: 'Navigation' }); const sidebar = await waitForSidebar(page);
await expect(sidebar).toBeVisible({ timeout: 15_000 });
const rookEntry = sidebar.getByRole('button', { name: /rook/i }); const rookEntry = sidebar.getByRole('button', { name: /rook/i });
await expect(rookEntry).toBeVisible(); await expect(rookEntry).toBeVisible();
await rookEntry.click(); await rookEntry.click();
await expect(page).toHaveURL(/\/rook-ceph/); await page.waitForLoadState('networkidle');
await expect(page).toHaveURL(/rook-ceph/);
await expect(page.getByRole('heading', { name: /overview/i })).toBeVisible(); await expect(page.getByRole('heading', { name: /overview/i })).toBeVisible();
}); });
test('overview page renders content', async ({ page }) => { test('overview page renders content', async ({ page }) => {
await page.goto('/c/main/rook-ceph'); await page.goto('/c/main/rook-ceph');
await waitForSidebar(page);
await expect(page.getByRole('heading', { name: /overview/i })).toBeVisible({ await expect(page.getByRole('heading', { name: /overview/i })).toBeVisible({
timeout: 15_000, timeout: 15_000,
@@ -41,12 +48,14 @@ test.describe('Rook plugin smoke tests', () => {
await expect(storageClassesLink).toBeVisible({ timeout: 10_000 }); await expect(storageClassesLink).toBeVisible({ timeout: 10_000 });
await storageClassesLink.click(); await storageClassesLink.click();
await expect(page).toHaveURL(/\/rook-ceph\/storage-classes/); await page.waitForLoadState('networkidle');
await expect(page).toHaveURL(/rook-ceph\/storage-classes/);
await expect(page.getByRole('heading', { name: /storage class/i })).toBeVisible({ timeout: 15_000 }); await expect(page.getByRole('heading', { name: /storage class/i })).toBeVisible({ timeout: 15_000 });
}); });
test('plugin settings page shows rook plugin entry', async ({ page }) => { test('plugin settings page shows rook plugin entry', async ({ page }) => {
await page.goto('/settings/plugins'); await page.goto('/settings/plugins');
await page.waitForLoadState('networkidle');
const pluginEntry = page.locator('text=rook').first(); const pluginEntry = page.locator('text=rook').first();
await expect(pluginEntry).toBeVisible({ timeout: 30_000 }); await expect(pluginEntry).toBeVisible({ timeout: 30_000 });