Compare commits

..

2 Commits

Author SHA1 Message Date
Chris Farhood 53508db0a9 fix(e2e): use @main ref for reusable workflow after pnpm fix (PRI-859) 2026-05-06 11:53:45 +00:00
privilegedescalation-engineer[bot] b9174a292e fix: override elliptic for GHSA-848j-6mx2-7j84
Add pnpm.overrides.elliptic to prevent version regression on
the transitive elliptic vulnerability (CVE-2025-14505).

Vulnerability path:
@kinvolk/headlamp-plugin → vite-plugin-node-polyfills →
node-stdlib-browser → crypto-browserify → browserify-sign → elliptic

Note: pnpm audit will still report the vulnerability until
upstream publishes elliptic 6.6.2+. This override safeguards
against pulling a worse version.

Co-authored-by: Chris Farhood <chris@farhood.org>
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-05-06 02:14:13 +00:00
3 changed files with 8 additions and 12 deletions
+1 -1
View File
@@ -18,6 +18,6 @@ jobs:
e2e: e2e:
uses: privilegedescalation/.github/.github/workflows/plugin-e2e.yaml@main uses: privilegedescalation/.github/.github/workflows/plugin-e2e.yaml@main
with: with:
node-version: "22" node-version: '22'
headlamp-version: v0.40.1 headlamp-version: v0.40.1
e2e-namespace: headlamp-dev e2e-namespace: headlamp-dev
+5 -10
View File
@@ -24,14 +24,14 @@ test.describe('Rook plugin smoke tests', () => {
await page.waitForLoadState('networkidle'); await page.waitForLoadState('networkidle');
await expect(page).toHaveURL(/rook-ceph/); await expect(page).toHaveURL(/rook-ceph/);
await expect(page.getByRole('heading', { name: /overview/i }).first()).toBeVisible(); await expect(page.getByRole('heading', { name: /overview/i })).toBeVisible();
}); });
test('overview page renders content', async ({ page }) => { test('overview page renders content', async ({ page }) => {
await page.goto('/c/main/rook-ceph'); await page.goto('/c/main/rook-ceph');
await waitForSidebar(page); await waitForSidebar(page);
await expect(page.getByRole('heading', { name: /overview/i }).first()).toBeVisible({ await expect(page.getByRole('heading', { name: /overview/i })).toBeVisible({
timeout: 15_000, timeout: 15_000,
}); });
@@ -42,27 +42,22 @@ test.describe('Rook plugin smoke tests', () => {
test('navigation to storage classes view works', async ({ page }) => { test('navigation to storage classes view works', async ({ page }) => {
await page.goto('/c/main/rook-ceph'); await page.goto('/c/main/rook-ceph');
const sidebar = page.getByRole('navigation', { name: 'Navigation' }); const sidebar = page.getByRole('navigation', { name: 'Navigation' });
const rookBtn = sidebar.getByRole('button', { name: /rook/i });
await rookBtn.click();
await page.waitForLoadState('networkidle');
const storageClassesLink = sidebar.getByRole('link', { name: /storage classes/i }); const storageClassesLink = sidebar.getByRole('link', { name: /storage classes/i });
await expect(storageClassesLink).toBeVisible({ timeout: 10_000 }); await expect(storageClassesLink).toBeVisible({ timeout: 10_000 });
await storageClassesLink.click(); await storageClassesLink.click();
await page.waitForLoadState('networkidle'); await page.waitForLoadState('networkidle');
await expect(page).toHaveURL(/rook-ceph\/storage-classes/); await expect(page).toHaveURL(/rook-ceph\/storage-classes/);
await expect(page.getByRole('heading', { name: /storage class/i }).first()).toBeVisible({ timeout: 15_000 }); await expect(page.getByRole('heading', { name: /storage class/i })).toBeVisible({ timeout: 15_000 });
}); });
test('plugin settings page shows rook plugin entry', async ({ page }) => { test('plugin settings page shows rook plugin entry', async ({ page }) => {
await page.goto('/settings/plugins'); await page.goto('/settings/plugins');
await page.waitForLoadState('networkidle'); await page.waitForLoadState('networkidle');
await page.waitForSelector('table, [class*="PluginList"], [class*="plugin"]', { timeout: 10_000 }).catch(() => {});
const pluginEntry = page.locator('text=/rook/i').first(); const pluginEntry = page.locator('text=rook').first();
await expect(pluginEntry).toBeVisible({ timeout: 30_000 }); await expect(pluginEntry).toBeVisible({ timeout: 30_000 });
}); });
}); });
+2 -1
View File
@@ -50,6 +50,7 @@
"tar": "^7.5.11", "tar": "^7.5.11",
"undici": "^7.24.3", "undici": "^7.24.3",
"vite": ">=6.4.2", "vite": ">=6.4.2",
"lodash": ">=4.18.0" "lodash": ">=4.18.0",
"elliptic": ">=6.6.1"
} }
} }