privilegedescalation/headlamp-rook-plugin
12
0
Fork 0
Code Issues 8 Pull Requests 1 Actions Packages Projects Releases 14 Wiki Activity

fix: add npm overrides for tar and undici security advisories #17

Merged
ghost merged 1 commits from fix/dep-security-overrides-tar-undici into main 2026-03-18 23:14:07 +00:00
Conversation 2 Commits 1 Files Changed 1
+4
ghost commented 2026-03-18 22:56:06 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Adds npm overrides for tar (^7.5.11) and undici (^7.24.3) to package.json
  • These overrides address CVE security advisories in transitive dependencies pulled in via @kinvolk/headlamp-plugin
  • Since we don't control the direct dependency's resolution, npm overrides ensure the patched versions are used throughout the dependency tree

Test plan

  • Verify npm install completes without errors
  • Verify npm audit no longer flags tar or undici advisories
  • Verify plugin build (npm run build) succeeds with overrides in place
## Summary - Adds npm `overrides` for `tar` (^7.5.11) and `undici` (^7.24.3) to `package.json` - These overrides address CVE security advisories in transitive dependencies pulled in via `@kinvolk/headlamp-plugin` - Since we don't control the direct dependency's resolution, npm overrides ensure the patched versions are used throughout the dependency tree ## Test plan - [ ] Verify `npm install` completes without errors - [ ] Verify `npm audit` no longer flags `tar` or `undici` advisories - [ ] Verify plugin build (`npm run build`) succeeds with overrides in place
Chris Farhood approved these changes 2026-03-18 23:03:33 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

QA Review: ✅ CI passes on this PR branch. npm overrides for tar (7.5.11) and undici (7.24.4) are correctly applied. Note: The repo has pre-existing missing devDependencies (vitest, @testing-library/*), but this is not caused by this PR - the shared CI workflow handles this appropriately.

QA Review: ✅ CI passes on this PR branch. npm overrides for tar (7.5.11) and undici (7.24.4) are correctly applied. Note: The repo has pre-existing missing devDependencies (vitest, @testing-library/*), but this is not caused by this PR - the shared CI workflow handles this appropriately.
Chris Farhood approved these changes 2026-03-18 23:08:26 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

CI green. Security overrides for tar/undici look correct. Merging.

CI green. Security overrides for tar/undici look correct. Merging.
Sign in to join this conversation.
Reviewers
No Reviewers
Chris Farhood
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-rook-plugin#17
Delete Branch "fix/dep-security-overrides-tar-undici"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?