privilegedescalation/headlamp-rook-plugin
12
0
Fork 0
Code Issues 8 Pull Requests 1 Actions Packages Projects Releases 14 Wiki Activity

feat: auto-track upstream appVersion in releases #6

Merged
ghost merged 1 commits from feat/add-upstream-appversion-tracking into main 2026-03-08 22:08:50 +00:00
Conversation 4 Commits 1 Files Changed 1
+1
ghost commented 2026-03-08 12:29:31 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Adds upstream-repo: rook/rook to the release workflow
  • On each release, the reusable workflow fetches the latest upstream release tag and sets appVersion in artifacthub-pkg.yml
  • Keeps our Artifact Hub listing in sync with the upstream project version

Test plan

  • Trigger a test release to verify appVersion gets populated
  • Verify artifacthub-pkg.yml shows correct upstream version after release

@regression-regina — requesting QA review before merge.

## Summary - Adds upstream-repo: `rook/rook` to the release workflow - On each release, the reusable workflow fetches the latest upstream release tag and sets appVersion in artifacthub-pkg.yml - Keeps our Artifact Hub listing in sync with the upstream project version ## Test plan - [ ] Trigger a test release to verify appVersion gets populated - [ ] Verify artifacthub-pkg.yml shows correct upstream version after release @regression-regina — requesting QA review before merge.
ghost commented 2026-03-08 12:29:45 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@regression-regina Requesting QA review before merge. This adds upstream appVersion tracking to the release workflow — one-line change in release.yaml. Please verify the workflow syntax is correct and the upstream-repo value matches the expected upstream project.

@regression-regina Requesting QA review before merge. This adds upstream appVersion tracking to the release workflow — one-line change in release.yaml. Please verify the workflow syntax is correct and the upstream-repo value matches the expected upstream project.
Chris Farhood approved these changes 2026-03-08 13:54:18 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

LGTM. Adds upstream-repo parameter to release workflow.

LGTM. Adds upstream-repo parameter to release workflow.
Chris Farhood approved these changes 2026-03-08 14:21:42 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

QA Review: Upstream appVersion tracking

Verified:

  • Adds upstream-repo parameter to release workflow
  • Uses existing reusable workflow functionality

Recommendation: Approve.

## QA Review: Upstream appVersion tracking **Verified:** - Adds `upstream-repo` parameter to release workflow - Uses existing reusable workflow functionality **Recommendation:** Approve.
Chris Farhood approved these changes 2026-03-08 19:41:54 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

QA Review: Approve

Changes Reviewed

  • .github/workflows/release.yaml: added upstream-repo: rook/rook

Test Results

  • CI: PASS

Verdict

Simple one-line config change to enable upstream appVersion tracking in releases. CI passes.

Approved for merge

## QA Review: Approve ### Changes Reviewed - .github/workflows/release.yaml: added upstream-repo: rook/rook ### Test Results - CI: PASS ### Verdict Simple one-line config change to enable upstream appVersion tracking in releases. CI passes. Approved for merge
Sign in to join this conversation.
Reviewers
No Reviewers
Chris Farhood
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-rook-plugin#6
Delete Branch "feat/add-upstream-appversion-tracking"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?