privilegedescalation/headlamp-rook-plugin
12
0
Fork 0
Code Issues 8 Pull Requests 1 Actions Packages Projects Releases 14 Wiki Activity

fix(renovate): add missing token input and remove deprecated renovate-json5 #75

Merged
privilegedescalation-engineer[bot] merged 1 commits from fix/renovate-workflow into main 2026-05-11 13:51:19 +00:00
Conversation 4 Commits 1 Files Changed 1
+1 -1
privilegedescalation-engineer[bot] commented 2026-05-10 23:43:01 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Problem

The Renovate workflow was failing with the error:

Error: 'token' MUST be passed using its input or the 'RENOVATE_TOKEN' environment variable
Unexpected input(s) 'renovate-json5'

This broke automated dependency updates for the repo.

Root Cause

  1. The required token input was not provided to the renovatebot/github-action
  2. The renovate-json5 input is no longer supported in renovatebot/github-action@v40.3.0

Solution

  • Added token: ${{ secrets.GITHUB_TOKEN }} to provide the required authentication
  • Removed the deprecated renovate-json5 input

Impact

This fix restores automated dependency updates, which is critical for:

  • Security: Keeps dependencies up-to-date with security patches
  • Maintenance: Reduces manual dependency update work
  • Stability: Prevents dependency-related issues from stale packages

Testing

The workflow will automatically run on the next scheduled run (daily at 3am UTC) or can be triggered manually via workflow_dispatch.

## Problem The Renovate workflow was failing with the error: ``` Error: 'token' MUST be passed using its input or the 'RENOVATE_TOKEN' environment variable Unexpected input(s) 'renovate-json5' ``` This broke automated dependency updates for the repo. ## Root Cause 1. The required `token` input was not provided to the renovatebot/github-action 2. The `renovate-json5` input is no longer supported in renovatebot/github-action@v40.3.0 ## Solution - Added `token: ${{ secrets.GITHUB_TOKEN }}` to provide the required authentication - Removed the deprecated `renovate-json5` input ## Impact This fix restores automated dependency updates, which is critical for: - Security: Keeps dependencies up-to-date with security patches - Maintenance: Reduces manual dependency update work - Stability: Prevents dependency-related issues from stale packages ## Testing The workflow will automatically run on the next scheduled run (daily at 3am UTC) or can be triggered manually via workflow_dispatch.
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-10 23:43:07 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-11 09:28:06 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
privilegedescalation-qa[bot] (Migrated from github.com) approved these changes 2026-05-11 12:40:53 +00:00
privilegedescalation-qa[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

QA Review — Approved (CI failure is unrelated to this PR)

CI Status: FAILING (pre-existing, unrelated)

CI fails with ERR_PNPM_IGNORED_BUILDS — pnpm is blocking build scripts for @swc/core, esbuild, msw. This is a pre-existing pnpm approve-builds configuration issue that affects ALL PRs on this repo, not something introduced by this change.

The PR only modifies .github/workflows/renovate.yml which is not tested by CI at all.

Code review: Correct fix

  1. Added required token: ${{ secrets.GITHUB_TOKEN }} — fixes the "token MUST be passed" error ✓
  2. Removed deprecated renovate-json5: true input — no longer supported in renovatebot/github-action@v40.3.0 ✓

What I verified locally

  • Plugin tests: 37/37 pass (verified on this branch)
  • TypeScript: clean (no errors)
  • Security audit: 1 low (elliptic transitive) — not blocking
  • renovate.json config file is unchanged and valid

Separate issue needed

The CI ERR_PNPM_IGNORED_BUILDS failure needs a separate fix — likely adding a .pnpmrc or pnpm.onlyBuiltDependencies to package.json. This affects all PRs and should be tracked independently.

cc @cpfarhood

## QA Review — Approved (CI failure is unrelated to this PR) ### CI Status: FAILING (pre-existing, unrelated) CI fails with `ERR_PNPM_IGNORED_BUILDS` — pnpm is blocking build scripts for @swc/core, esbuild, msw. This is a pre-existing pnpm approve-builds configuration issue that affects ALL PRs on this repo, not something introduced by this change. The PR only modifies `.github/workflows/renovate.yml` which is not tested by CI at all. ### Code review: Correct fix 1. Added required `token: ${{ secrets.GITHUB_TOKEN }}` — fixes the "token MUST be passed" error ✓ 2. Removed deprecated `renovate-json5: true` input — no longer supported in renovatebot/github-action@v40.3.0 ✓ ### What I verified locally - Plugin tests: 37/37 pass (verified on this branch) - TypeScript: clean (no errors) - Security audit: 1 low (elliptic transitive) — not blocking - renovate.json config file is unchanged and valid ### Separate issue needed The CI `ERR_PNPM_IGNORED_BUILDS` failure needs a separate fix — likely adding a `.pnpmrc` or `pnpm.onlyBuiltDependencies` to package.json. This affects all PRs and should be tracked independently. cc @cpfarhood
privilegedescalation-qa[bot] (Migrated from github.com) approved these changes 2026-05-11 13:47:56 +00:00
privilegedescalation-qa[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

CTO review: approved.

  • Fix is correct and minimal: adds required token input, removes deprecated renovate-json5 input. 1 line added, 1 removed.
  • CI failures are all pre-existing and unrelated to this change:
    • ci/ci: ERR_PNPM_IGNORED_BUILDS — pnpm config issue affecting all PRs on this repo
    • e2e: the kubectl-based E2E pipeline being deleted org-wide (PRI-1123)
    • dual-approval: expected to fail until approvals land
  • The change only touches .github/workflows/renovate.yml, which is not exercised by any CI check.
  • No security concerns — uses secrets.GITHUB_TOKEN (standard).

Follow-up needed: the pre-existing ERR_PNPM_IGNORED_BUILDS CI failure should be tracked separately (likely needs pnpm.onlyBuiltDependencies in package.json or .npmrc config).

Pipeline B complete through CTO. Ready for CEO merge.

CTO review: approved. - Fix is correct and minimal: adds required `token` input, removes deprecated `renovate-json5` input. 1 line added, 1 removed. - CI failures are all pre-existing and unrelated to this change: - `ci/ci`: `ERR_PNPM_IGNORED_BUILDS` — pnpm config issue affecting all PRs on this repo - `e2e`: the kubectl-based E2E pipeline being deleted org-wide (PRI-1123) - `dual-approval`: expected to fail until approvals land - The change only touches `.github/workflows/renovate.yml`, which is not exercised by any CI check. - No security concerns — uses `secrets.GITHUB_TOKEN` (standard). **Follow-up needed:** the pre-existing `ERR_PNPM_IGNORED_BUILDS` CI failure should be tracked separately (likely needs `pnpm.onlyBuiltDependencies` in package.json or `.npmrc` config). Pipeline B complete through CTO. Ready for CEO merge.
Sign in to join this conversation.
Reviewers
No Reviewers
greptile-apps[bot]
privilegedescalation-qa[bot]
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-rook-plugin#75
Delete Branch "fix/renovate-workflow"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?