privilegedescalation/headlamp-rook-plugin
12
0
Fork 0
Code Issues 8 Pull Requests 1 Actions Packages Projects Releases 14 Wiki Activity

fix: standardize pnpm to 10.32.1 to match other headlamp plugins #80

Merged
privilegedescalation-ceo[bot] merged 1 commits from fix/standardize-pnpm-version into main 2026-05-20 03:03:48 +00:00
Conversation 1 Commits 1 Files Changed 1
+1 -1
privilegedescalation-ceo[bot] commented 2026-05-11 23:02:51 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Updates packageManager field from pnpm@9.15.4 to pnpm@10.32.1 to ensure consistency across all headlamp plugins.

Context

All other headlamp plugins (argocd-plugin, polaris-plugin, sealed-secrets-plugin) use pnpm@10.32.1. The rook-plugin was using pnpm@9.15.4 due to a previous workaround for pnpm@latest (11.x) build script approval issues.

Changes

  • Update package.json packageManager field from pnpm@9.15.4 to pnpm@10.32.1

Testing

Verified locally:

  • pnpm run tsc - passed
  • pnpm run lint - passed (with pre-existing indentation warnings)
  • pnpm run format:check - passed
  • pnpm test - all 37 tests passed

The pnpm lockfile remains unchanged as the dependency resolution is identical between pnpm@9.15.4 and pnpm@10.32.1 for this project.

Related

  • Related to PRI-1236: CI failing on main branch for headlamp-sealed-secrets-plugin and headlamp-rook-plugin
## Summary Updates `packageManager` field from `pnpm@9.15.4` to `pnpm@10.32.1` to ensure consistency across all headlamp plugins. ## Context All other headlamp plugins (argocd-plugin, polaris-plugin, sealed-secrets-plugin) use pnpm@10.32.1. The rook-plugin was using pnpm@9.15.4 due to a previous workaround for pnpm@latest (11.x) build script approval issues. ## Changes - Update `package.json` `packageManager` field from `pnpm@9.15.4` to `pnpm@10.32.1` ## Testing Verified locally: - `pnpm run tsc` - passed - `pnpm run lint` - passed (with pre-existing indentation warnings) - `pnpm run format:check` - passed - `pnpm test` - all 37 tests passed The pnpm lockfile remains unchanged as the dependency resolution is identical between pnpm@9.15.4 and pnpm@10.32.1 for this project. ## Related - Related to [PRI-1236](/PRI/issues/PRI-1236): CI failing on main branch for headlamp-sealed-secrets-plugin and headlamp-rook-plugin
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-11 23:07:59 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
Countess von Containerheim merged commit 0fcc1acb98 into main 2026-05-20 03:03:48 +00:00
Countess von Containerheim deleted branch fix/standardize-pnpm-version 2026-05-20 03:03:49 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
greptile-apps[bot]
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-rook-plugin#80
Delete Branch "fix/standardize-pnpm-version"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?