privilegedescalation/headlamp-rook-plugin
12
0
Fork 0
Code Issues 8 Pull Requests 1 Actions Packages Projects Releases 14 Wiki Activity

feat(e2e): consolidate E2E infra + fix flaky storage-classes test (PRI-699) #56

Closed
privilegedescalation-engineer[bot] wants to merge 4 commits from gandalf/e2e-fix into main
pull from: gandalf/e2e-fix
merge into: privilegedescalation:main
Conversation 4 Commits 4 Files Changed 2
+12 -7
privilegedescalation-engineer[bot] commented 2026-05-05 13:05:22 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Consolidates E2E test infrastructure for headlamp-rook-plugin and fixes two test reliability issues.

What this PR does

  • Adds e2e/auth.setup.ts, e2e/rook.spec.ts, playwright.config.ts, scripts/deploy-e2e-headlamp.sh, scripts/teardown-e2e-headlamp.sh (all from main)
  • Fixes navigation to storage classes view works test: the 'Storage Classes' link is nested under the Rook sidebar button — expands Rook section before asserting link visibility
  • Fixes plugin settings page shows rook plugin entry test: uses case-insensitive /rook/i regex and waits for plugin list to render before searching

Test reliability notes

E2E tests require:

  1. Service account headlamp-e2e-test in headlamp-dev namespace with cluster-scoped permissions for storageclasses, persistentvolumes, persistentvolumeclaims, cephclusters, cephblockpools, cephfilesystems, cephobjectstores (and Rook CRDs)
  2. Valid token via kubectl create token headlamp-e2e-test -n headlamp-dev --duration=1h

These RBAC requirements are tracked in PRI-702.

References

## Summary Consolidates E2E test infrastructure for `headlamp-rook-plugin` and fixes two test reliability issues. ### What this PR does - Adds `e2e/auth.setup.ts`, `e2e/rook.spec.ts`, `playwright.config.ts`, scripts/deploy-e2e-headlamp.sh, scripts/teardown-e2e-headlamp.sh (all from `main`) - Fixes `navigation to storage classes view works` test: the 'Storage Classes' link is nested under the Rook sidebar button — expands Rook section before asserting link visibility - Fixes `plugin settings page shows rook plugin entry` test: uses case-insensitive `/rook/i` regex and waits for plugin list to render before searching ### Test reliability notes E2E tests require: 1. Service account `headlamp-e2e-test` in `headlamp-dev` namespace with cluster-scoped permissions for `storageclasses`, `persistentvolumes`, `persistentvolumeclaims`, `cephclusters`, `cephblockpools`, `cephfilesystems`, `cephobjectstores` (and Rook CRDs) 2. Valid token via `kubectl create token headlamp-e2e-test -n headlamp-dev --duration=1h` These RBAC requirements are tracked in [PRI-702](/PRI/issues/PRI-702). ### References - [PRI-697](/PRI/issues/PRI-697) - [PRI-699](/PRI/issues/PRI-699)
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-05 13:05:30 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-05 13:56:42 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-05 17:44:06 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
privilegedescalation-engineer[bot] commented 2026-05-05 19:14:06 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closing — superseded by #61 (canonical E2E consolidation PR). E2E infra changes have been consolidated into a single PR per repo per PRI-779.

Closing — superseded by #61 (canonical E2E consolidation PR). E2E infra changes have been consolidated into a single PR per repo per PRI-779.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
greptile-apps[bot]
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-rook-plugin#56
Delete Branch "gandalf/e2e-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?