privilegedescalation/headlamp-rook-plugin
12
0
Fork 0
Code Issues 8 Pull Requests 1 Actions Packages Projects Releases 14 Wiki Activity

fix(e2e): stale sidebar locator in storage-classes test (PRI-699) #57

Closed
privilegedescalation-engineer[bot] wants to merge 5 commits from gandalf/fix-flaky-storage-class into main
pull from: gandalf/fix-flaky-storage-class
merge into: privilegedescalation:main
Conversation 3 Commits 5 Files Changed 2
+18 -9
privilegedescalation-engineer[bot] commented 2026-05-05 14:02:56 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Fixes the flaky navigation to storage classes view works E2E test on PR #56.

Root cause

After clicking the Rook button in the sidebar, the test captured a sidebar reference before the page transition completed. The storageClassesLink locator was resolved against a stale sidebar state, causing the visibility assertion at line 52 to timeout.

Fix

  • Re-acquire sidebar reference after clicking Rook button (sidebarAfterClick)
  • Use waitFor({ state: 'visible' }) instead of expect().toBeVisible() for the storage-classes link — gives Playwright's locators time to re-resolve after DOM update

Testing

  • E2E run will validate the fix (targeting gandalf/e2e-fix as base)
  • CI must pass

References

cc @cpfarhood

## Summary Fixes the flaky `navigation to storage classes view works` E2E test on [PR #56](/privilegedescalation/headlamp-rook-plugin/pull/56). ## Root cause After clicking the Rook button in the sidebar, the test captured a sidebar reference before the page transition completed. The `storageClassesLink` locator was resolved against a stale sidebar state, causing the visibility assertion at line 52 to timeout. ## Fix - Re-acquire sidebar reference after clicking Rook button (`sidebarAfterClick`) - Use `waitFor({ state: 'visible' })` instead of `expect().toBeVisible()` for the storage-classes link — gives Playwright's locators time to re-resolve after DOM update ## Testing - E2E run will validate the fix (targeting `gandalf/e2e-fix` as base) - CI must pass ## References - Parent: [PRI-699](/PRI/issues/PRI-699) - Parent escalation: [PRI-697](/PRI/issues/PRI-697) cc @cpfarhood
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-05 14:03:03 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-05 17:44:03 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
privilegedescalation-engineer[bot] commented 2026-05-05 19:14:07 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closing — superseded by #61 (canonical E2E consolidation PR). E2E infra changes have been consolidated into a single PR per repo per PRI-779.

Closing — superseded by #61 (canonical E2E consolidation PR). E2E infra changes have been consolidated into a single PR per repo per PRI-779.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
greptile-apps[bot]
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-rook-plugin#57
Delete Branch "gandalf/fix-flaky-storage-class"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?