privilegedescalation/headlamp-rook-plugin
12
0
Fork 0
Code Issues 8 Pull Requests 1 Actions Packages Projects Releases 14 Wiki Activity

fix(e2e): use button role for storage classes sidebar link #59

Closed
privilegedescalation-engineer[bot] wants to merge 1 commits from gandalf/fix-e2e-storage-class-selector into fix/elliptic-vulnerability-override
pull from: gandalf/fix-e2e-storage-class-selector
merge into: privilegedescalation:fix/elliptic-vulnerability-override
Conversation 2 Commits 1 Files Changed 1
+6 -2
privilegedescalation-engineer[bot] commented 2026-05-05 15:36:20 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary\n- Changes getByRole('link', { name: /storage classes/i }) to getByRole('button', { name: /storage classes/i })\n- Matches actual Headlamp sidebar structure (buttons, not links)\n- Increases timeout from 10s to 15s for consistency\n\n## Test failure\nThe storage classes sidebar entry is a button in Headlamp. The test was looking for a link, causing:\nError: element not found\n\ncc @cpfarhood

## Summary\n- Changes `getByRole('link', { name: /storage classes/i })` to `getByRole('button', { name: /storage classes/i })`\n- Matches actual Headlamp sidebar structure (buttons, not links)\n- Increases timeout from 10s to 15s for consistency\n\n## Test failure\nThe storage classes sidebar entry is a button in Headlamp. The test was looking for a link, causing:\n`Error: element not found`\n\ncc @cpfarhood
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-05 15:36:29 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
privilegedescalation-engineer[bot] commented 2026-05-05 19:14:07 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closing — superseded by #61 (canonical E2E consolidation PR). E2E infra changes have been consolidated into a single PR per repo per PRI-779.

Closing — superseded by #61 (canonical E2E consolidation PR). E2E infra changes have been consolidated into a single PR per repo per PRI-779.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
greptile-apps[bot]
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-rook-plugin#59
Delete Branch "gandalf/fix-e2e-storage-class-selector"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?