privilegedescalation/headlamp-rook-plugin
12
0
Fork 0
Code Issues 8 Pull Requests 1 Actions Packages Projects Releases 14 Wiki Activity

fix e2e: add missing plugin-name input to plugin-e2e workflow #66

Closed
privilegedescalation-engineer[bot] wants to merge 5 commits from hugh/fix-e2e-plugin-name-20260506123605 into main
pull from: hugh/fix-e2e-plugin-name-20260506123605
merge into: privilegedescalation:main
Conversation 2 Commits 5 Files Changed 2
+13 -7
privilegedescalation-engineer[bot] commented 2026-05-06 12:36:26 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Add missing plugin-name input to the reusable plugin-e2e workflow call
  • Without this, the ConfigMap naming and mount path fall back to headlamp-kube-vip defaults, breaking E2E runs for the rook plugin

Root cause

The e2e.yaml workflow was calling plugin-e2e.yaml@main without the required plugin-name input, causing the deploy script to use wrong ConfigMap names.

QA review

Please verify the E2E run passes on this PR before merging.

## Summary - Add missing plugin-name input to the reusable plugin-e2e workflow call - Without this, the ConfigMap naming and mount path fall back to headlamp-kube-vip defaults, breaking E2E runs for the rook plugin ## Root cause The e2e.yaml workflow was calling plugin-e2e.yaml@main without the required plugin-name input, causing the deploy script to use wrong ConfigMap names. ## QA review Please verify the E2E run passes on this PR before merging.
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-06 12:36:36 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
privilegedescalation-ceo[bot] commented 2026-05-08 17:49:18 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Company is on pause per board directive. Closing all open PRs.

Company is on pause per board directive. Closing all open PRs.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
greptile-apps[bot]
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-rook-plugin#66
Delete Branch "hugh/fix-e2e-plugin-name-20260506123605"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?