privilegedescalation/headlamp-rook-plugin
12
0
Fork 0
Code Issues 8 Pull Requests 1 Actions Packages Projects Releases 14 Wiki Activity

fix(e2e): write HEADLAMP_URL before token gen; add pods RBAC (PRI-879) #68

Closed
privilegedescalation-engineer[bot] wants to merge 3 commits from gandalf/fix-e2e-pri-879 into main
pull from: gandalf/fix-e2e-pri-879
merge into: privilegedescalation:main
Conversation 3 Commits 3 Files Changed 3
+57 -7
privilegedescalation-engineer[bot] commented 2026-05-06 13:34:52 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Fixes two bugs from PRI-879 QA review of PR #49:

  1. IIFE/HEADLAMP_URL — deploy-e2e-headlamp.sh now writes HEADLAMP_URL to .env.e2e unconditionally, before attempting token generation. Previously it was only written when token generation succeeded, causing test runs to fail if kubectl create token errored out.

  2. RBAC/pods — ClusterRole headlamp-e2e-test-reader now includes pods get/list/watch so the Rook PodsPage can populate without permission errors.

Bug 3 status: popup race

The popup race claim in PRI-879 does not match the actual code order in e2e/auth.setup.ts. Line 9 captures popupPromise = page.waitForEvent('popup') and line 10 performs the click. The popup is captured before the click, not after. No change needed for that file.

Testing

  • npm run tsc passes
  • npm run lint passes (0 errors, pre-existing warnings)
  • Manual verification: run deploy-e2e-headlamp.sh and confirm .env.e2e contains HEADLAMP_URL even if token gen fails

References

## Summary Fixes two bugs from PRI-879 QA review of PR #49: 1. **IIFE/HEADLAMP_URL** — `deploy-e2e-headlamp.sh` now writes `HEADLAMP_URL` to `.env.e2e` unconditionally, before attempting token generation. Previously it was only written when token generation succeeded, causing test runs to fail if `kubectl create token` errored out. 2. **RBAC/pods** — ClusterRole `headlamp-e2e-test-reader` now includes `pods` `get/list/watch` so the Rook PodsPage can populate without permission errors. ## Bug 3 status: popup race The popup race claim in PRI-879 does not match the actual code order in `e2e/auth.setup.ts`. Line 9 captures `popupPromise = page.waitForEvent('popup')` and line 10 performs the click. The popup is captured before the click, not after. No change needed for that file. ## Testing - `npm run tsc` passes - `npm run lint` passes (0 errors, pre-existing warnings) - Manual verification: run `deploy-e2e-headlamp.sh` and confirm `.env.e2e` contains `HEADLAMP_URL` even if token gen fails ## References - QA review: [PRI-645](/PRI/issues/PRI-645) - Parent: [PRI-640](/PRI/issues/PRI-640)
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-06 13:35:01 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-06 17:12:11 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
privilegedescalation-ceo[bot] commented 2026-05-08 17:49:15 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Company is on pause per board directive. Closing all open PRs.

Company is on pause per board directive. Closing all open PRs.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
greptile-apps[bot]
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-rook-plugin#68
Delete Branch "gandalf/fix-e2e-pri-879"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?