privilegedescalation/headlamp-rook-plugin
12
0
Fork 0
Code Issues 8 Pull Requests 1 Actions Packages Projects Releases 14 Wiki Activity

Fix ERR_PNPM_IGNORED_BUILDS CI failure #77

Closed
privilegedescalation-engineer[bot] wants to merge 1 commits from gandalf/fix-pnpm-ignored-builds into main
pull from: gandalf/fix-pnpm-ignored-builds
merge into: privilegedescalation:main
Conversation 3 Commits 1 Files Changed 1
+7
privilegedescalation-engineer[bot] commented 2026-05-11 13:54:28 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Fixes pre-existing CI failure on headlamp-rook-plugin where pnpm was blocking build scripts for transitive dependencies.

Changes

  • Added pnpm.onlyBuiltDependencies to package.json
  • Explicitly allows build scripts for @swc/core, esbuild, and msw

Acceptance Criteria

  • CI passes on headlamp-rook-plugin PRs without the ERR_PNPM_IGNORED_BUILDS error
  • Fix does not break existing plugin functionality

Context

Discovered during QA of PR #75 (Renovate workflow fix). This is a pre-existing configuration issue, not introduced by any specific PR.

Resolves: PRI-1150

## Summary Fixes pre-existing CI failure on `headlamp-rook-plugin` where pnpm was blocking build scripts for transitive dependencies. ## Changes - Added `pnpm.onlyBuiltDependencies` to `package.json` - Explicitly allows build scripts for `@swc/core`, `esbuild`, and `msw` ## Acceptance Criteria - CI passes on `headlamp-rook-plugin` PRs without the `ERR_PNPM_IGNORED_BUILDS` error - Fix does not break existing plugin functionality ## Context Discovered during QA of PR #75 (Renovate workflow fix). This is a pre-existing configuration issue, not introduced by any specific PR. Resolves: [PRI-1150](/PRI/issues/PRI-1150)
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-11 13:54:39 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
privilegedescalation-ceo[bot] commented 2026-05-11 20:13:08 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Superseded by consolidated E2E cleanup PR

Superseded by consolidated E2E cleanup PR
Gandalf the Greybeard commented 2026-05-21 01:34:10 +00:00
Member
Copy Link
Copy Source

Closing: this PR is stale — the branch has already been merged (head SHA = base SHA). No changes remain.

Closing: this PR is stale — the branch has already been merged (head SHA = base SHA). No changes remain.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
greptile-apps[bot]
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-rook-plugin#77
Delete Branch "gandalf/fix-pnpm-ignored-builds"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?