From 37391cd92adf4105c8e1d7a8c58772450be50674 Mon Sep 17 00:00:00 2001 From: Chris Farhood Date: Thu, 12 Feb 2026 17:40:50 -0500 Subject: [PATCH] fix: move node-forge to devDependencies for proper bundling Moving node-forge from dependencies to devDependencies ensures it gets bundled into the plugin instead of being externalized. This is required because Headlamp doesn't provide node-forge as a shared library. The .pluginrc file with empty externals forces bundling of all deps, and keeping node-forge in devDependencies makes this behavior explicit. This fixes the frontend loading error: "TypeError: undefined is not an object (evaluating 'Ot.KubeObject')" Changes: - Moved node-forge from dependencies to devDependencies - Updated package-lock.json to mark node-forge as dev dependency - .pluginrc remains in place to enforce bundling Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude Co-Authored-By: Happy --- headlamp-sealed-secrets/package-lock.json | 9 ++++----- headlamp-sealed-secrets/package.json | 4 +--- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/headlamp-sealed-secrets/package-lock.json b/headlamp-sealed-secrets/package-lock.json index a37cafb..0957905 100644 --- a/headlamp-sealed-secrets/package-lock.json +++ b/headlamp-sealed-secrets/package-lock.json @@ -1,20 +1,18 @@ { "name": "headlamp-sealed-secrets", - "version": "0.2.2", + "version": "0.2.5", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "headlamp-sealed-secrets", - "version": "0.2.2", + "version": "0.2.5", "license": "Apache-2.0", - "dependencies": { - "node-forge": "^1.3.1" - }, "devDependencies": { "@iconify/react": "^6.0.2", "@kinvolk/headlamp-plugin": "^0.13.0", "@types/node-forge": "^1.3.11", + "node-forge": "^1.3.1", "typedoc": "^0.28.16", "typedoc-plugin-markdown": "^4.10.0" } @@ -12399,6 +12397,7 @@ "version": "1.3.3", "resolved": "https://registry.npmjs.org/node-forge/-/node-forge-1.3.3.tgz", "integrity": "sha512-rLvcdSyRCyouf6jcOIPe/BgwG/d7hKjzMKOas33/pHEr6gbq18IK9zV7DiPvzsz0oBJPme6qr6H6kGZuI9/DZg==", + "dev": true, "license": "(BSD-3-Clause OR GPL-2.0)", "engines": { "node": ">= 6.13.0" diff --git a/headlamp-sealed-secrets/package.json b/headlamp-sealed-secrets/package.json index f078860..4a4bd66 100644 --- a/headlamp-sealed-secrets/package.json +++ b/headlamp-sealed-secrets/package.json @@ -56,13 +56,11 @@ "overrides": { "typescript": "5.6.2" }, - "dependencies": { - "node-forge": "^1.3.1" - }, "devDependencies": { "@iconify/react": "^6.0.2", "@kinvolk/headlamp-plugin": "^0.13.0", "@types/node-forge": "^1.3.11", + "node-forge": "^1.3.1", "typedoc": "^0.28.16", "typedoc-plugin-markdown": "^4.10.0" }