privilegedescalation/headlamp-sealed-secrets-plugin
12
0
Fork 0
Code Issues 2 Pull Requests 2 Actions Packages Projects Releases 27 Wiki Activity

fix: add missing archive-checksum annotation for Artifact Hub #4

Merged
ghost merged 1 commits from fix/artifacthub-checksum-annotation into main 2026-03-07 17:47:29 +00:00
Conversation 1 Commits 1 Files Changed 1
+1
ghost commented 2026-03-07 17:07:09 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Adds the required headlamp/plugin/archive-checksum annotation placeholder to artifacthub-pkg.yml
  • The release workflow's "Compute checksum" step uses sed to replace this annotation with the actual SHA256 hash at release time — but it requires the line to already exist
  • Without it, Artifact Hub rejects the package metadata with: required annotation "headlamp/plugin/archive-checksum" not provided

Root cause

The annotation was never added to the file. The sed substitution in .github/workflows/release.yaml (line 93) silently no-ops when the target line doesn't exist.

Test plan

  • Verify CI passes
  • Next release workflow run should populate the checksum correctly
  • Artifact Hub should accept the package metadata after the next release

Resolves PRI-15

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

## Summary - Adds the required `headlamp/plugin/archive-checksum` annotation placeholder to `artifacthub-pkg.yml` - The release workflow's "Compute checksum" step uses `sed` to replace this annotation with the actual SHA256 hash at release time — but it requires the line to already exist - Without it, Artifact Hub rejects the package metadata with: `required annotation "headlamp/plugin/archive-checksum" not provided` ## Root cause The annotation was never added to the file. The `sed` substitution in `.github/workflows/release.yaml` (line 93) silently no-ops when the target line doesn't exist. ## Test plan - [ ] Verify CI passes - [ ] Next release workflow run should populate the checksum correctly - [ ] Artifact Hub should accept the package metadata after the next release Resolves PRI-15 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Chris Farhood approved these changes 2026-03-07 17:13:36 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

LGTM. Verified the release workflow — sed on line 93 of release.yaml does s|headlamp/plugin/archive-checksum:.*|...|, which requires the annotation line to exist. This adds it with an empty value that gets replaced at release time with the actual SHA256. Clean, minimal fix. CI green.

Approved — ready for board merge.

LGTM. Verified the release workflow — `sed` on line 93 of `release.yaml` does `s|headlamp/plugin/archive-checksum:.*|...|`, which requires the annotation line to exist. This adds it with an empty value that gets replaced at release time with the actual SHA256. Clean, minimal fix. CI green. Approved — ready for board merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Chris Farhood
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-sealed-secrets-plugin#4
Delete Branch "fix/artifacthub-checksum-annotation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?