From a324cfe7103f3a42664fd435f7efca0b2fb4d560 Mon Sep 17 00:00:00 2001 From: Chris Farhood Date: Tue, 5 May 2026 15:41:56 +0000 Subject: [PATCH 1/5] fix(e2e): add E2E workflow for headlamp-sealed-secrets-plugin Adds .github/workflows/e2e.yaml calling the shared plugin-e2e.yaml reusable workflow. Fixes PRI-729: E2E DNS failure caused by missing E2E workflow in this repo. Co-Authored-By: Paperclip --- .github/workflows/e2e.yaml | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 .github/workflows/e2e.yaml diff --git a/.github/workflows/e2e.yaml b/.github/workflows/e2e.yaml new file mode 100644 index 0000000..fef1a13 --- /dev/null +++ b/.github/workflows/e2e.yaml @@ -0,0 +1,23 @@ +name: E2E Tests + +on: + push: + branches: [main] + pull_request: + branches: [main] + workflow_dispatch: + +permissions: + contents: read + +concurrency: + group: e2e-${{ github.repository }} + cancel-in-progress: false + +jobs: + e2e: + uses: privilegedescalation/.github/.github/workflows/plugin-e2e.yaml@hugh/add-pnpm-support-plugin-e2e + with: + node-version: "22" + headlamp-version: v0.40.1 + e2e-namespace: headlamp-dev -- 2.52.0 From 33a99552cabaf5c74028208d6c81e8f07c5c39a8 Mon Sep 17 00:00:00 2001 From: Chris Farhood Date: Tue, 5 May 2026 17:43:36 +0000 Subject: [PATCH 2/5] fix(e2e): reference @main workflow after .github merge Update workflow_call ref from hugh/add-pnpm-support-plugin-e2e to main now that .github#144 has merged. Co-Authored-By: Paperclip --- .github/workflows/e2e.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/e2e.yaml b/.github/workflows/e2e.yaml index fef1a13..0363889 100644 --- a/.github/workflows/e2e.yaml +++ b/.github/workflows/e2e.yaml @@ -16,7 +16,7 @@ concurrency: jobs: e2e: - uses: privilegedescalation/.github/.github/workflows/plugin-e2e.yaml@hugh/add-pnpm-support-plugin-e2e + uses: privilegedescalation/.github/.github/workflows/plugin-e2e.yaml@main with: node-version: "22" headlamp-version: v0.40.1 -- 2.52.0 From d659718fd62cd262a6c60ba7126e39574bd7414f Mon Sep 17 00:00:00 2001 From: Chris Farhood Date: Tue, 5 May 2026 17:51:39 +0000 Subject: [PATCH 3/5] fix(e2e): use pnpm-capable workflow branch Reference @hugh/add-pnpm-support-plugin-e2e which has pnpm support via corepack. PRI-634 --- .github/workflows/e2e.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/e2e.yaml b/.github/workflows/e2e.yaml index 0363889..fef1a13 100644 --- a/.github/workflows/e2e.yaml +++ b/.github/workflows/e2e.yaml @@ -16,7 +16,7 @@ concurrency: jobs: e2e: - uses: privilegedescalation/.github/.github/workflows/plugin-e2e.yaml@main + uses: privilegedescalation/.github/.github/workflows/plugin-e2e.yaml@hugh/add-pnpm-support-plugin-e2e with: node-version: "22" headlamp-version: v0.40.1 -- 2.52.0 From db0624f4a5b3e400eec1682d142369bd37b7df9e Mon Sep 17 00:00:00 2001 From: Chris Farhood Date: Tue, 5 May 2026 17:56:20 +0000 Subject: [PATCH 4/5] fix(e2e): reference @main workflow after .github merge Co-Authored-By: Paperclip --- .github/workflows/e2e.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/e2e.yaml b/.github/workflows/e2e.yaml index fef1a13..0363889 100644 --- a/.github/workflows/e2e.yaml +++ b/.github/workflows/e2e.yaml @@ -16,7 +16,7 @@ concurrency: jobs: e2e: - uses: privilegedescalation/.github/.github/workflows/plugin-e2e.yaml@hugh/add-pnpm-support-plugin-e2e + uses: privilegedescalation/.github/.github/workflows/plugin-e2e.yaml@main with: node-version: "22" headlamp-version: v0.40.1 -- 2.52.0 From 1fe9a6264a2971c27f00ca82eee4f7ea788057ef Mon Sep 17 00:00:00 2001 From: Chris Farhood Date: Tue, 5 May 2026 18:47:01 +0000 Subject: [PATCH 5/5] fix(e2e): disable automount SA token to avoid kubelet fetch race Kubelet tries to fetch SA token immediately after deployment creates the pod, but the SA may not be propagated yet. Setting automountServiceAccountToken: false avoids this race. The SA token is not needed since E2E tests authenticate via HEADLAMP_TOKEN passed as env var. --- scripts/deploy-e2e-headlamp.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/deploy-e2e-headlamp.sh b/scripts/deploy-e2e-headlamp.sh index 8f7a872..31bb566 100755 --- a/scripts/deploy-e2e-headlamp.sh +++ b/scripts/deploy-e2e-headlamp.sh @@ -97,7 +97,7 @@ spec: app.kubernetes.io/instance: ${E2E_RELEASE} spec: serviceAccountName: ${E2E_RELEASE} - automountServiceAccountToken: true + automountServiceAccountToken: false securityContext: {} containers: - name: headlamp @@ -159,6 +159,7 @@ spec: EOF echo "Waiting for rollout..." +sleep 2 kubectl rollout status "deployment/${E2E_RELEASE}" \ -n "$E2E_NAMESPACE" --timeout=120s -- 2.52.0