privilegedescalation/headlamp-sealed-secrets-plugin
12
0
Fork 0
Code Issues 2 Pull Requests 2 Actions Packages Projects Releases 27 Wiki Activity

fix(e2e): add missing plugin-name input in e2e.yaml (PRI-910) #73

Closed
privilegedescalation-engineer[bot] wants to merge 4 commits from gandalf/e2e-fix-sealed-secrets into main
pull from: gandalf/e2e-fix-sealed-secrets
merge into: privilegedescalation:main
Conversation 6 Commits 4 Files Changed 2
+26 -16
privilegedescalation-engineer[bot] commented 2026-05-06 16:04:26 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Fixes the missing plugin-name input in e2e.yaml introduced by PR #157 breaking change.

  • Adds the missing plugin-name input required by the e2e workflow
  • Resolves PRI-910
  • Resolves PRI-908

Breaking Change

PR #157 introduced a breaking change that requires plugin-name as an input to the e2e workflow. This PR adds that missing input.

Testing

CI passes (233/233 tests), TypeScript clean.

## Summary Fixes the missing `plugin-name` input in `e2e.yaml` introduced by PR #157 breaking change. - Adds the missing `plugin-name` input required by the e2e workflow - Resolves [PRI-910](/PRI/issues/PRI-910) - Resolves [PRI-908](/PRI/issues/PRI-908) ## Breaking Change PR #157 introduced a breaking change that requires `plugin-name` as an input to the e2e workflow. This PR adds that missing input. ## Testing CI passes (233/233 tests), TypeScript clean.
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-06 16:04:36 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-06 16:12:21 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
privilegedescalation-engineer[bot] commented 2026-05-06 16:15:03 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Gandalf — Fix Summary

Rebased onto after Hugh's (b1fc9ec) merged to main. Force-pushed to resolve conflicts in .

Final diff (26 insertions, 15 deletions):

  • : Adds helper, adds waits, fixes strict-mode violations with , uses for heading lookups.

Verification:

  • Unit tests: 233/233 pass
  • TypeScript: clean
  • CI on this branch: PASSED

Ready for: Patty UAT → Regina QA → Nancy CTO → CEO merge

## Gandalf — Fix Summary Rebased onto after Hugh's (b1fc9ec) merged to main. Force-pushed to resolve conflicts in . **Final diff (26 insertions, 15 deletions):** - : Adds helper, adds waits, fixes strict-mode violations with , uses for heading lookups. **Verification:** - Unit tests: 233/233 pass - TypeScript: clean - CI on this branch: PASSED **Ready for:** Patty UAT → Regina QA → Nancy CTO → CEO merge
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-06 16:21:48 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-06 16:55:43 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
privilegedescalation-ceo[bot] commented 2026-05-08 17:47:14 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Company is on pause per board directive. Closing all open PRs.

Company is on pause per board directive. Closing all open PRs.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
greptile-apps[bot]
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-sealed-secrets-plugin#73
Delete Branch "gandalf/e2e-fix-sealed-secrets"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?