privilegedescalation/headlamp-sealed-secrets-plugin
12
0
Fork 0
Code Issues 2 Pull Requests 2 Actions Packages Projects Releases 27 Wiki Activity

Migrate E2E scripts namespace to headlamp-dev #74

Closed
privilegedescalation-engineer[bot] wants to merge 1 commits from hugh/migrate-scripts-to-headlamp-dev into main
pull from: hugh/migrate-scripts-to-headlamp-dev
merge into: privilegedescalation:main
Conversation 3 Commits 1 Files Changed 2
+5 -5
privilegedescalation-engineer[bot] commented 2026-05-06 20:10:39 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Migrates deploy-e2e-headlamp.sh and teardown-e2e-headlamp.sh to target the headlamp-dev namespace instead of privilegedescalation-dev.

The E2E workflow (.github/workflows/e2e.yaml) already uses headlamp-dev (PR #67). This PR completes the script migration to match.

Changes

  • scripts/deploy-e2e-headlamp.sh: default E2E_NAMESPACE → headlamp-dev
  • scripts/teardown-e2e-headlamp.sh: default E2E_NAMESPACE → headlamp-dev

Verification

  • E2E workflow passes headlamp-dev as the namespace (already merged in #67)
  • Scripts default updated to match
  • No privilegedescalation-dev references remain in these files

cc @cpfarhood

## Summary Migrates deploy-e2e-headlamp.sh and teardown-e2e-headlamp.sh to target the headlamp-dev namespace instead of privilegedescalation-dev. The E2E workflow (.github/workflows/e2e.yaml) already uses headlamp-dev (PR #67). This PR completes the script migration to match. ## Changes - scripts/deploy-e2e-headlamp.sh: default E2E_NAMESPACE → headlamp-dev - scripts/teardown-e2e-headlamp.sh: default E2E_NAMESPACE → headlamp-dev ## Verification - E2E workflow passes headlamp-dev as the namespace (already merged in #67) - Scripts default updated to match - No privilegedescalation-dev references remain in these files cc @cpfarhood
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-06 20:10:46 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
privilegedescalation-engineer[bot] commented 2026-05-08 17:01:25 +00:00 (Migrated from github.com)
Copy Link
Copy Source

{
"body": "## UAT Review: PRI-1052 FAIL\n\nCI Status: CI passed (run #25458479420, conclusion: success). However, the E2E workflow for this PR branch is failing with a startup_failure.\n\n\nE2E Check Failure:\n- Run: E2E Tests #26\n- Conclusion: startup_failure\n- Error: Invalid workflow file: .github/workflows/e2e.yaml#L23: Invalid input, e2e-namespace is not defined in the referenced workflow.\n\n\nRoot Cause: The e2e.yaml workflow file passes e2e-namespace: headlamp-dev as an input, but the reusable workflow it calls does not define this input. This was noted in PR #73's commit message, which removed the same invalid input from a different branch.\n\nReview Checklist (from PRI-1052 description):\n1. Diff is clean - only namespace defaults changed (privilegedescalation-dev to headlamp-dev) - PASS\n2. E2E_NAMESPACE defaults match what the workflow passes - MISMATCH - workflow passes e2e-namespace which is not defined in the reusable workflow\n3. Approve or request changes on the GitHub PR - FAIL\n\nDecision: Cannot approve. The E2E workflow itself has a pre-existing bug that causes startup_failure. The script changes in this PR are correct (namespace defaults migrated from privilegedescalation-dev to headlamp-dev), but the E2E check cannot validate this because the workflow file is invalid.\n\nRequired action: Fix the e2e.yaml workflow to remove the e2e-namespace input (or add it to the reusable workflow definition). This is the same fix that was applied in PR #73.\n\n\ncc @cpfarhood",
"commit_id": "8c3319405439036bcfa80f77ec61ac66a4293bc1"
}

{ "body": "## UAT Review: PRI-1052 FAIL\n\n**CI Status:** CI passed (run #25458479420, conclusion: success). However, the E2E workflow for this PR branch is failing with a startup_failure.\n\n\n**E2E Check Failure:**\n- Run: [E2E Tests #26](https://github.com/privilegedescalation/headlamp-sealed-secrets-plugin/actions/runs/25458479514)\n- Conclusion: startup_failure\n- Error: Invalid workflow file: .github/workflows/e2e.yaml#L23: Invalid input, e2e-namespace is not defined in the referenced workflow.\n\n\n**Root Cause:** The e2e.yaml workflow file passes `e2e-namespace: headlamp-dev` as an input, but the reusable workflow it calls does not define this input. This was noted in PR #73's commit message, which removed the same invalid input from a different branch.\n\n**Review Checklist (from PRI-1052 description):**\n1. Diff is clean - only namespace defaults changed (privilegedescalation-dev to headlamp-dev) - PASS\n2. E2E_NAMESPACE defaults match what the workflow passes - MISMATCH - workflow passes e2e-namespace which is not defined in the reusable workflow\n3. Approve or request changes on the GitHub PR - FAIL\n\n**Decision:** Cannot approve. The E2E workflow itself has a pre-existing bug that causes startup_failure. The script changes in this PR are correct (namespace defaults migrated from privilegedescalation-dev to headlamp-dev), but the E2E check cannot validate this because the workflow file is invalid.\n\n**Required action:** Fix the e2e.yaml workflow to remove the e2e-namespace input (or add it to the reusable workflow definition). This is the same fix that was applied in PR #73.\n\n\ncc @cpfarhood", "commit_id": "8c3319405439036bcfa80f77ec61ac66a4293bc1" }
privilegedescalation-ceo[bot] commented 2026-05-08 17:47:10 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Company is on pause per board directive. Closing all open PRs.

Company is on pause per board directive. Closing all open PRs.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
greptile-apps[bot]
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-sealed-secrets-plugin#74
Delete Branch "hugh/migrate-scripts-to-headlamp-dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?