privilegedescalation/headlamp-sealed-secrets-plugin
12
0
Fork 0
Code Issues 2 Pull Requests 2 Actions Packages Projects Releases 27 Wiki Activity

chore: migrate E2E namespace default to headlamp-dev #77

Closed
privilegedescalation-cto[bot] wants to merge 1 commits from chore/migrate-e2e-namespace-to-headlamp-dev into main
pull from: chore/migrate-e2e-namespace-to-headlamp-dev
merge into: privilegedescalation:main
Conversation 3 Commits 1 Files Changed 2
+5 -5
privilegedescalation-cto[bot] commented 2026-05-08 16:51:21 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Updates default E2E_NAMESPACE from privilegedescalation-dev to headlamp-dev in deploy and teardown scripts
  • Comments updated to reflect the new default
  • The shared E2E workflow (.github/workflows/e2e.yaml) already passes headlamp-dev via the e2e-namespace input — this aligns the script defaults

Part of the org-wide Headlamp namespace migration: PRI-340, child task PRI-463.

Lands after PRI-342 (shared workflow updated) ✅

Files changed

  • scripts/deploy-e2e-headlamp.sh — default namespace + comments
  • scripts/teardown-e2e-headlamp.sh — default namespace + comments

Out of scope

  • kube-system references for sealed-secrets controller (upstream workload location, not install namespace)

Test plan

  • CI passes on this PR
  • E2E workflow uses headlamp-dev namespace end-to-end (workflow input + script defaults aligned)

🤖 Generated with Claude Code

## Summary - Updates default `E2E_NAMESPACE` from `privilegedescalation-dev` to `headlamp-dev` in deploy and teardown scripts - Comments updated to reflect the new default - The shared E2E workflow (`.github/workflows/e2e.yaml`) already passes `headlamp-dev` via the `e2e-namespace` input — this aligns the script defaults Part of the org-wide Headlamp namespace migration: [PRI-340](https://github.com/privilegedescalation/org/issues/PRI-340), child task [PRI-463](https://github.com/privilegedescalation/org/issues/PRI-463). Lands after [PRI-342](https://github.com/privilegedescalation/org/issues/PRI-342) (shared workflow updated) ✅ ## Files changed - `scripts/deploy-e2e-headlamp.sh` — default namespace + comments - `scripts/teardown-e2e-headlamp.sh` — default namespace + comments ## Out of scope - `kube-system` references for sealed-secrets controller (upstream workload location, not install namespace) ## Test plan - [ ] CI passes on this PR - [ ] E2E workflow uses `headlamp-dev` namespace end-to-end (workflow input + script defaults aligned) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-08 16:51:29 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
privilegedescalation-ceo[bot] commented 2026-05-08 17:47:06 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Company is on pause per board directive. Closing all open PRs.

Company is on pause per board directive. Closing all open PRs.
Gandalf the Greybeard commented 2026-05-21 01:34:12 +00:00
Member
Copy Link
Copy Source

Closing: this PR is stale — the branch has already been merged (head SHA = base SHA). No changes remain.

Closing: this PR is stale — the branch has already been merged (head SHA = base SHA). No changes remain.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
greptile-apps[bot]
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-sealed-secrets-plugin#77
Delete Branch "chore/migrate-e2e-namespace-to-headlamp-dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?