privilegedescalation/headlamp-tns-csi-plugin
12
0
Fork 0
Code Issues 1 Pull Requests 2 Actions Packages Projects Releases 13 Wiki Activity

fix: add npm overrides for tar and undici security advisories #11

Merged
ghost merged 2 commits from fix/dep-security-overrides-tar-undici into main 2026-03-18 23:14:05 +00:00
Conversation 3 Commits 2 Files Changed 2
+10 -6
ghost commented 2026-03-18 22:55:55 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Adds npm overrides for tar (^7.5.11) and undici (^7.24.3) to package.json
  • These overrides address CVE security advisories in transitive dependencies pulled in via @kinvolk/headlamp-plugin
  • Since these packages are deep transitive deps, npm overrides are the correct mechanism to force resolution to patched versions without waiting for upstream to update their dependency trees

Test plan

  • Verify npm install completes without errors
  • Verify npm audit no longer reports advisories for tar or undici
  • Verify plugin builds successfully with npm run build
## Summary - Adds npm `overrides` for `tar` (^7.5.11) and `undici` (^7.24.3) to `package.json` - These overrides address CVE security advisories in transitive dependencies pulled in via `@kinvolk/headlamp-plugin` - Since these packages are deep transitive deps, npm overrides are the correct mechanism to force resolution to patched versions without waiting for upstream to update their dependency trees ## Test plan - [ ] Verify `npm install` completes without errors - [ ] Verify `npm audit` no longer reports advisories for `tar` or `undici` - [ ] Verify plugin builds successfully with `npm run build`
Chris Farhood requested changes 2026-03-18 23:05:36 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

CI failed on this PR branch. The issue appears to be pre-existing - the repo has missing devDependencies (vitest, @testing-library/*) which causes tsc to fail locally. This is not caused by the npm overrides in this PR. Please verify CI passes before I can approve.

CI failed on this PR branch. The issue appears to be pre-existing - the repo has missing devDependencies (vitest, @testing-library/*) which causes tsc to fail locally. This is not caused by the npm overrides in this PR. Please verify CI passes before I can approve.
Chris Farhood approved these changes 2026-03-18 23:13:32 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

CI green. Security overrides for tar/undici verified. Enabling auto-merge.

CI green. Security overrides for tar/undici verified. Enabling auto-merge.
Chris Farhood approved these changes 2026-03-18 23:13:41 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

Verified the dependency security overrides:

  • tar upgraded from 7.5.9 to 7.5.11
  • undici upgraded from 7.22.0 to 7.24.4
  • TypeScript compiles without errors
  • npm audit shows 0 vulnerabilities

CI passes (run #23271492973). The local test failures are a pre-existing environmental issue (React running in production mode) - not related to this PR.

Verified the dependency security overrides: - `tar` upgraded from 7.5.9 to 7.5.11 - `undici` upgraded from 7.22.0 to 7.24.4 - TypeScript compiles without errors - `npm audit` shows 0 vulnerabilities CI passes (run #23271492973). The local test failures are a pre-existing environmental issue (React running in production mode) - not related to this PR.
Sign in to join this conversation.
Reviewers
No Reviewers
Chris Farhood
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-tns-csi-plugin#11
Delete Branch "fix/dep-security-overrides-tar-undici"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?