privilegedescalation/headlamp-tns-csi-plugin
12
0
Fork 0
Code Issues 1 Pull Requests 2 Actions Packages Projects Releases 13 Wiki Activity

fix: add missing devDependencies for CI #12

Merged
ghost merged 1 commits from fix/add-missing-devdependencies into main 2026-03-18 23:43:53 +00:00
Conversation 3 Commits 1 Files Changed 2
+807 -519
ghost commented 2026-03-18 23:27:00 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Adds missing devDependencies: vitest, @testing-library/jest-dom, @testing-library/react, @testing-library/user-event, jsdom, react, react-dom, react-router-dom
  • Adds peerDependencies for react/react-dom to match reference plugin conventions
  • Regenerates package-lock.json with all dependencies resolved

The package.json previously only listed @kinvolk/headlamp-plugin as a devDependency, but CI runs tsc, eslint, prettier, and vitest — all of which require these additional packages. Versions match the reference kube-vip plugin.

Test plan

  • npm run tsc passes
  • npm run lint passes (warnings only, no errors)
  • npm run format:check passes
  • npm test passes (159/159 tests)
  • npm audit --omit=dev passes (0 vulnerabilities)
  • CI workflow passes on this PR

Fixes: privilegedescalation/headlamp-tns-csi-plugin CI

🤖 Generated with Claude Code

## Summary - Adds missing devDependencies: `vitest`, `@testing-library/jest-dom`, `@testing-library/react`, `@testing-library/user-event`, `jsdom`, `react`, `react-dom`, `react-router-dom` - Adds `peerDependencies` for `react`/`react-dom` to match reference plugin conventions - Regenerates `package-lock.json` with all dependencies resolved The `package.json` previously only listed `@kinvolk/headlamp-plugin` as a devDependency, but CI runs `tsc`, `eslint`, `prettier`, and `vitest` — all of which require these additional packages. Versions match the reference kube-vip plugin. ## Test plan - [x] `npm run tsc` passes - [x] `npm run lint` passes (warnings only, no errors) - [x] `npm run format:check` passes - [x] `npm test` passes (159/159 tests) - [x] `npm audit --omit=dev` passes (0 vulnerabilities) - [ ] CI workflow passes on this PR Fixes: privilegedescalation/headlamp-tns-csi-plugin CI 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Chris Farhood approved these changes 2026-03-18 23:41:10 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

QA Review ✓

Verified the following:

  • TypeScript: passes
  • Lint: passes (11 warnings, 0 errors - pre-existing)
  • Format: passes
  • Tests: 159/159 tests pass (requires in local environment, CI sets this correctly)
  • Security audit: passes (0 vulnerabilities)
  • CI: Latest run on this branch shows success

The PR correctly adds missing devDependencies needed for CI to run tests, lint, typecheck, and format checks. Also adds appropriate peerDependencies for react/react-dom to match Headlamp plugin conventions.

Note: Tests fail locally without due to React running in production mode. This is expected - the CI workflow correctly sets NODE_ENV=development when running tests.

## QA Review ✓ Verified the following: - **TypeScript**: passes - **Lint**: passes (11 warnings, 0 errors - pre-existing) - **Format**: passes - **Tests**: 159/159 tests pass (requires in local environment, CI sets this correctly) - **Security audit**: passes (0 vulnerabilities) - **CI**: Latest run on this branch shows success The PR correctly adds missing devDependencies needed for CI to run tests, lint, typecheck, and format checks. Also adds appropriate peerDependencies for react/react-dom to match Headlamp plugin conventions. **Note**: Tests fail locally without due to React running in production mode. This is expected - the CI workflow correctly sets NODE_ENV=development when running tests.
Chris Farhood approved these changes 2026-03-18 23:41:39 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

QA Review ✓

Verified the following:

  • TypeScript: npm run tsc passes
  • Lint: npm run lint passes (11 warnings, 0 errors - pre-existing)
  • Format: npm run format:check passes
  • Tests: 159/159 tests pass (requires NODE_ENV=development in local environment, CI sets this correctly)
  • Security audit: npm audit --omit=dev passes (0 vulnerabilities)
  • CI: Latest run on this branch shows success

The PR correctly adds missing devDependencies needed for CI to run tests, lint, typecheck, and format checks. Also adds appropriate peerDependencies for react/react-dom to match Headlamp plugin conventions.

Note: Tests fail locally without NODE_ENV=development due to React running in production mode. This is expected - the CI workflow correctly sets NODE_ENV=development when running tests.

## QA Review ✓ Verified the following: - **TypeScript**: `npm run tsc` passes - **Lint**: `npm run lint` passes (11 warnings, 0 errors - pre-existing) - **Format**: `npm run format:check` passes - **Tests**: 159/159 tests pass (requires `NODE_ENV=development` in local environment, CI sets this correctly) - **Security audit**: `npm audit --omit=dev` passes (0 vulnerabilities) - **CI**: Latest run on this branch shows success The PR correctly adds missing devDependencies needed for CI to run tests, lint, typecheck, and format checks. Also adds appropriate peerDependencies for react/react-dom to match Headlamp plugin conventions. **Note**: Tests fail locally without `NODE_ENV=development` due to React running in production mode. This is expected - the CI workflow correctly sets NODE_ENV=development when running tests.
Chris Farhood approved these changes 2026-03-18 23:43:47 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

CI green, QA verified. Approved.

CI green, QA verified. Approved.
Sign in to join this conversation.
Reviewers
No Reviewers
Chris Farhood
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-tns-csi-plugin#12
Delete Branch "fix/add-missing-devdependencies"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?