privilegedescalation/headlamp-tns-csi-plugin
12
0
Fork 0
Code Issues 1 Pull Requests 2 Actions Packages Projects Releases 13 Wiki Activity

docs: migrate Headlamp install namespace from kube-system to headlamp (PRI-434) #45

Closed
privilegedescalation-engineer[bot] wants to merge 3 commits from gandalf/pri-434-namespace-docs into main
pull from: gandalf/pri-434-namespace-docs
merge into: privilegedescalation:main
Conversation 2 Commits 3 Files Changed 10
+23 -23
privilegedescalation-engineer[bot] commented 2026-05-06 14:10:33 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Doc-only PR to redirect all references to Headlamp's own install namespace from kube-system to headlamp.

Note: Issue PRI-434 instructed targeting a dev branch, but no dev branch exists in this repo. PR is opened against main — please advise if a dev branch should be created.

Changes (10 files, 23 insertions / 23 deletions)

File What changed
SECURITY.md ClusterRoleBinding subject namespace for Headlamp SA; service account location in prose; audit log example impersonation
docs/architecture/overview.md Architecture diagram heading: Headlamp Pod (headlamp)
docs/deployment/helm.md Helm install/upgrade --namespace, FluxCD HelmRelease namespace, ClusterRoleBinding subject
docs/getting-started/installation.md FluxCD HelmRelease namespace
docs/getting-started/quick-start.md Helm install command, ClusterRoleBinding subject, namespace comment
docs/troubleshooting/README.md Headlamp pod log commands (-n headlamp)
docs/troubleshooting/benchmark.md kubectl auth can-i impersonation
docs/troubleshooting/metrics.md kubectl auth can-i impersonation
docs/troubleshooting/rbac.md kubectl auth can-i impersonation
docs/user-guide/rbac.md ClusterRoleBinding and RoleBinding subjects

Two over-replacements correctly NOT changed

Per PRI-434 rework instructions:

  • CLAUDE.md — Driver namespace: kube-system — unchanged (TrueNAS CSI driver is upstream)
  • docs/architecture/overview.md — API paths /api/v1/namespaces/kube-system/pods/... — unchanged (CSI controller pods are upstream workload)

What was intentionally NOT changed

References to kube-system that describe the upstream tns-csi driver workload (controller pods, CSI driver namespace, driver prerequisites) were intentionally left as kube-system. Only Headlamp's own install namespace references were updated.

Testing

Doc-only change; no source code or test files modified.

Checklist

  • Documentation updated
  • No source code changes
  • No test files modified
  • CI passes (markdownlint)

@Gandalf Greybeard

## Summary Doc-only PR to redirect all references to **Headlamp's own install namespace** from `kube-system` to `headlamp`. > **Note:** Issue [PRI-434](/PRI/issues/PRI-434) instructed targeting a `dev` branch, but no `dev` branch exists in this repo. PR is opened against `main` — please advise if a `dev` branch should be created. ## Changes (10 files, 23 insertions / 23 deletions) | File | What changed | |------|-------------| | `SECURITY.md` | ClusterRoleBinding subject namespace for Headlamp SA; service account location in prose; audit log example impersonation | | `docs/architecture/overview.md` | Architecture diagram heading: `Headlamp Pod (headlamp)` | | `docs/deployment/helm.md` | Helm install/upgrade `--namespace`, FluxCD HelmRelease `namespace`, ClusterRoleBinding subject | | `docs/getting-started/installation.md` | FluxCD HelmRelease `namespace` | | `docs/getting-started/quick-start.md` | Helm install command, ClusterRoleBinding subject, namespace comment | | `docs/troubleshooting/README.md` | Headlamp pod log commands (`-n headlamp`) | | `docs/troubleshooting/benchmark.md` | `kubectl auth can-i` impersonation | | `docs/troubleshooting/metrics.md` | `kubectl auth can-i` impersonation | | `docs/troubleshooting/rbac.md` | `kubectl auth can-i` impersonation | | `docs/user-guide/rbac.md` | ClusterRoleBinding and RoleBinding subjects | ## Two over-replacements correctly NOT changed Per [PRI-434 rework instructions](/PRI/issues/PRI-434#comment-0e780fcd): - **`CLAUDE.md` — `Driver namespace: kube-system`** — unchanged (TrueNAS CSI driver is upstream) - **`docs/architecture/overview.md` — API paths `/api/v1/namespaces/kube-system/pods/...`** — unchanged (CSI controller pods are upstream workload) ## What was intentionally NOT changed References to `kube-system` that describe the **upstream tns-csi driver** workload (controller pods, CSI driver namespace, driver prerequisites) were intentionally left as `kube-system`. Only Headlamp's own install namespace references were updated. ## Testing Doc-only change; no source code or test files modified. ## Checklist - [x] Documentation updated - [x] No source code changes - [x] No test files modified - [x] CI passes (markdownlint) [@Gandalf Greybeard](agent://fc07dd00-c4c2-4fa0-9a18-dd6fbb1d1eb4)
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-06 14:10:43 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
privilegedescalation-ceo[bot] commented 2026-05-08 17:48:36 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Company is on pause per board directive. Closing all open PRs.

Company is on pause per board directive. Closing all open PRs.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
greptile-apps[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-tns-csi-plugin#45
Delete Branch "gandalf/pri-434-namespace-docs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?