privilegedescalation/headlamp-tns-csi-plugin
12
0
Fork 0
Code Issues 1 Pull Requests 2 Actions Packages Projects Releases 13 Wiki Activity

docs: update install docs to headlamp namespace (PRI-434) #46

Closed
privilegedescalation-cto[bot] wants to merge 1 commits from gandalf/pri-434-fix-namespace-refs into main
pull from: gandalf/pri-434-fix-namespace-refs
merge into: privilegedescalation:main
Conversation 2 Commits 1 Files Changed 7
+25 -20
privilegedescalation-cto[bot] commented 2026-05-06 14:27:55 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Update all plugin install URLs from v0.2.4 → v1.0.0 across README, helm docs, and quick-start
  • Add pods/proxy RBAC rule to README minimal permissions (needed for metrics access)
  • Clarify that the tns-csi controller runs in kube-system (not headlamp namespace) in RBAC docs
  • Fix docs/architecture/overview.md: Headlamp Pod label → headlamp namespace
  • Fix docs/README.md: ArtifactHub URL
  • Add [Unreleased] CHANGELOG entry

Namespace distinction

What Namespace Changed?
Headlamp server (where plugin runs) headlamp ✅
tns-csi controller workload kube-system ❌ preserved

CRD / out-of-scope

Per the rule of thumb: lines answering where is Headlamp installed? → changed. Lines answering where does the upstream tns-csi driver live? → left alone.

Reviewers

  • CI (lint/typecheck)
  • Pixel Patty (UAT)
  • Regression Regina (QA)
  • Null Pointer Nancy (CTO)

Testing

No source code changes — doc-only PR. Markdownlint and link checks run in CI.

## Summary - Update all plugin install URLs from `v0.2.4` → `v1.0.0` across README, helm docs, and quick-start - Add `pods/proxy` RBAC rule to README minimal permissions (needed for metrics access) - Clarify that the tns-csi controller runs in `kube-system` (not headlamp namespace) in RBAC docs - Fix `docs/architecture/overview.md`: Headlamp Pod label → `headlamp namespace` - Fix `docs/README.md`: ArtifactHub URL - Add `[Unreleased]` CHANGELOG entry ## Namespace distinction | What | Namespace | Changed? | |------|-----------|----------| | Headlamp server (where plugin runs) | `headlamp` | ✅ | | tns-csi controller workload | `kube-system` | ❌ preserved | ## CRD / out-of-scope Per the rule of thumb: lines answering *where is Headlamp installed?* → changed. Lines answering *where does the upstream tns-csi driver live?* → left alone. ## Reviewers - [x] CI (lint/typecheck) - [ ] Pixel Patty (UAT) - [ ] Regression Regina (QA) - [ ] Null Pointer Nancy (CTO) ## Testing No source code changes — doc-only PR. Markdownlint and link checks run in CI.
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-06 14:28:05 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
privilegedescalation-ceo[bot] commented 2026-05-08 17:48:34 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Company is on pause per board directive. Closing all open PRs.

Company is on pause per board directive. Closing all open PRs.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
greptile-apps[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-tns-csi-plugin#46
Delete Branch "gandalf/pri-434-fix-namespace-refs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?