privilegedescalation/org
Archived
12
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Update PR workflow: CI → UAT (Patty) → QA (Regina) → CTO → merge

Browse Source 
Reorder the review pipeline so cheap/fast stages gate expensive ones:
CI (free) runs first, then Patty validates E2E on MiniMax, then
Regina does deep code review on Sonnet, then Nancy reviews last.

- POLICIES.md: rewrite PR Workflow with 6-step ordered pipeline
- Patty SOUL.md: establish her as first reviewer, add CI-must-pass rule
- Patty HEARTBEAT.md: check CI status before E2E, report results for Regina
- Regina SOUL.md: flip from "review first" to "review after UAT"
- Regina HEARTBEAT.md: skip PRs without CI + E2E validation

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Chris Farhood
2026-03-24 20:52:05 -04:00
parent 9d9c85c310
commit 4ee7a5bf29
5 changed files with 18 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
POLICIES.md
+6 -4
View File
@@ -98,11 +98,13 @@ Agents must design their workflows to operate within existing permissions. If a
All code changes follow this lifecycle:
1. **Engineer opens a PR** from a feature branch (never push directly to main)
2. **QA (Regina) reviews first** — verifies tests, coverage, regressions, edge cases
3. **CTO (Nancy) reviews second** — verifies architecture alignment, code quality, security. **The CTO must NOT review or approve a PR before QA has approved it.**
4. **CEO (Countess) merges** — only after both QA and CTO have approved and CI passes
2. **CI passes** — lint, types, unit tests must all be green before any reviewer spends tokens
3. **UAT (Patty) validates E2E** — browser testing against the deployed build in `privilegedescalation-dev`. Patty only picks up PRs with passing CI.
4. **QA (Regina) reviews** — code-level review: test coverage, regressions, edge cases. Regina only picks up PRs that have passed both CI and E2E.
5. **CTO (Nancy) reviews** — architecture alignment, code quality, security. Nancy only reviews after both UAT and QA have approved.
6. **CEO (Countess) merges** — only after UAT + QA + CTO have approved and CI passes
**Review order is mandatory.** QA reviews first, CTO reviews second. If the CTO reviews before QA has approved, QA should refuse to review the PR until the process is corrected. A PR is not ready to merge until it has both QA and CTO approval in the correct order. No agent merges their own PRs. No agent merges without dual approval.
**Review order is mandatory: CI → UAT → QA → CTO → merge.** Each stage gates the next. If an agent reviews out of order, the earlier reviewer should refuse to review until the process is corrected — comment on the PR noting the violation. No agent merges their own PRs. No agent merges without triple approval (UAT + QA + CTO).
## Work Distribution