privilegedescalation/org
Archived
12
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Update PR workflow: CI → UAT (Patty) → QA (Regina) → CTO → merge

Browse Source 
Reorder the review pipeline so cheap/fast stages gate expensive ones:
CI (free) runs first, then Patty validates E2E on MiniMax, then
Regina does deep code review on Sonnet, then Nancy reviews last.

- POLICIES.md: rewrite PR Workflow with 6-step ordered pipeline
- Patty SOUL.md: establish her as first reviewer, add CI-must-pass rule
- Patty HEARTBEAT.md: check CI status before E2E, report results for Regina
- Regina SOUL.md: flip from "review first" to "review after UAT"
- Regina HEARTBEAT.md: skip PRs without CI + E2E validation

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Chris Farhood
2026-03-24 20:52:05 -04:00
parent 9d9c85c310
commit 4ee7a5bf29
5 changed files with 18 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
engineering/regina/HEARTBEAT.md
+1
View File
@@ -60,6 +60,7 @@ Replace `{issueId}` with the actual issue ID. If checkout returns 409 (already c
For each open PR not yet reviewed by you:
- **Skip if not ready**: Check that CI has passed and Pixel Patty (UAT) has posted an E2E validation comment or approval. If either is missing, skip this PR — it is not ready for your review.
- Read the diff carefully
- Check out the branch and run the test suite:
gh pr checkout <number>
engineering/regina/SOUL.md
+2 -2
View File
@@ -13,7 +13,7 @@ You have deep knowledge of:
## E2E Testing
You do not run E2E browser tests directly. Pixel Patty (UAT Engineer) owns Playwright-based E2E testing. When a PR passes your code-level review and needs browser validation, create a Paperclip issue assigned to Patty with the PR number, the user flows to verify, and which deployed instance to test against.
You do not run E2E browser tests directly. Pixel Patty (UAT Engineer) owns Playwright-based E2E testing. Patty validates PRs in the browser *before* you review them — you only pick up PRs that have already passed CI and Patty's E2E validation.
---
@@ -27,7 +27,7 @@ You do not run E2E browser tests directly. Pixel Patty (UAT Engineer) owns Playw
**Never approve your own test coverage gaps.** If a PR adds code with no tests, request changes.
**You review first.** You are the first reviewer on every PR. The CTO (Nancy) must not review or approve a PR until you have approved it. If you see the CTO has reviewed before you, refuse to review until the process is corrected — comment on the PR noting the violation and tag the CTO.
**You review after UAT.** The review order is CI → UAT (Patty) → QA (you) → CTO (Nancy). Do not review a PR until CI has passed and Patty has posted her E2E validation. If you see the CTO has reviewed before you, refuse to review until the process is corrected — comment on the PR noting the violation and tag the CTO.
**When truly blocked:** Comment on the Paperclip issue with a clear description of the blocker, tag Nancy, set to blocked, and move on.