From c31be7ef2568897485038b1aaedae3da761e8d7d Mon Sep 17 00:00:00 2001 From: Hugh Hackman Date: Wed, 25 Mar 2026 12:51:52 +0000 Subject: [PATCH 1/2] fix: add pr_number input to dual-approval-check workflow The dual-approval workflow was not re-triggering on pull_request_review events because the shared workflow was using github.event.pull_request.number which is not available in workflow_call context. This change adds a required pr_number input to the reusable workflow. Co-Authored-By: Paperclip --- .github/workflows/dual-approval-check.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/dual-approval-check.yaml b/.github/workflows/dual-approval-check.yaml index 5607475..840e8ba 100644 --- a/.github/workflows/dual-approval-check.yaml +++ b/.github/workflows/dual-approval-check.yaml @@ -20,6 +20,10 @@ name: Dual Approval Check on: workflow_call: inputs: + pr_number: + description: "Pull request number" + required: true + type: number cto-reviewer: description: "GitHub username of the CTO reviewer" required: false @@ -43,7 +47,7 @@ jobs: GH_TOKEN: ${{ github.token }} CTO_REVIEWER: ${{ inputs.cto-reviewer }} QA_REVIEWER: ${{ inputs.qa-reviewer }} - PR_NUMBER: ${{ github.event.pull_request.number }} + PR_NUMBER: ${{ inputs.pr_number }} REPO: ${{ github.repository }} run: | if [ -z "${PR_NUMBER}" ]; then From d0635c48708d2fe63270dba506ea7372fe369d72 Mon Sep 17 00:00:00 2001 From: Hugh Hackman Date: Wed, 25 Mar 2026 13:04:52 +0000 Subject: [PATCH 2/2] fix: make pr_number input optional in dual-approval-check PR #81 adds pr_number as a required input, but the 5 calling plugin repos don't yet pass this input. Change required: true to required: false so the workflow_call can succeed without it, while companion PRs are opened to add the input to each caller. Co-Authored-By: Paperclip --- .github/workflows/dual-approval-check.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/dual-approval-check.yaml b/.github/workflows/dual-approval-check.yaml index 840e8ba..39453c8 100644 --- a/.github/workflows/dual-approval-check.yaml +++ b/.github/workflows/dual-approval-check.yaml @@ -22,7 +22,7 @@ on: inputs: pr_number: description: "Pull request number" - required: true + required: false type: number cto-reviewer: description: "GitHub username of the CTO reviewer"