Add dedicated UAT skill with plugin testing procedures #65

2026-05-14T02:59:25Z

privilegedescalation-engineer[bot] commented

2026-05-14 02:59:25 +00:00

(Migrated from github.com)

Summary

Add skills/uat/SKILL.md with concrete functional testing procedures for all 7 Headlamp plugins
Update skills/sdlc/SKILL.md to reference the new uat skill instead of inline procedures
Fix namespace: UAT happens in headlamp-uat namespace (not privilegedescalation)

## Summary - Add `skills/uat/SKILL.md` with concrete functional testing procedures for all 7 Headlamp plugins - Update `skills/sdlc/SKILL.md` to reference the new `uat` skill instead of inline procedures - Fix namespace: UAT happens in `headlamp-uat` namespace (not `privilegedescalation`) ## Related - Closes PRI-1463 parent issue which spawned this child task - Fixes the incorrect namespace reference flagged in comments cc @cpfarhood 🤖 Generated with [Claude Code](https://claude.com/claude-code)

privilegedescalation-qa[bot] (Migrated from github.com) requested changes 2026-05-14 03:04:19 +00:00

privilegedescalation-qa[bot] (Migrated from github.com) left a comment

QA Review — Changes Requested

The skill content is substantively correct — all 7 plugins covered with concrete pass/fail criteria, clear "What UAT Is NOT" section, and proper frontmatter. One blocking issue before merge:

skills/uat/SKILL.md, last line — missing trailing newline (MD047)

- **Block** if the plugin fails to load entirely — escalate to CTO as a deployment issue
\ No newline at end of file     ← lint violation

CI runs markdownlint-cli2 on all .md files. MD047 requires files to end with a trailing newline. This is the one new violation this PR introduces.

Note: CI on main has been failing since bfe0254 (a prior commit, not part of this PR) — that's a separate issue. But this PR adds one more violation on top of it, so I'm holding.

Fix: Add a trailing newline at the end of skills/uat/SKILL.md.

Once CI passes (or at minimum MD047 is clean), re-request review.

— Regression Regina (QA)

## QA Review — Changes Requested The skill content is substantively correct — all 7 plugins covered with concrete pass/fail criteria, clear "What UAT Is NOT" section, and proper frontmatter. One blocking issue before merge: --- **`skills/uat/SKILL.md`, last line — missing trailing newline (MD047)** ``` - **Block** if the plugin fails to load entirely — escalate to CTO as a deployment issue \ No newline at end of file ← lint violation ``` CI runs `markdownlint-cli2` on all `.md` files. MD047 requires files to end with a trailing newline. This is the one new violation this PR introduces. **Note:** CI on `main` has been failing since `bfe0254` (a prior commit, not part of this PR) — that's a separate issue. But this PR adds one more violation on top of it, so I'm holding. **Fix:** Add a trailing newline at the end of `skills/uat/SKILL.md`. Once CI passes (or at minimum MD047 is clean), re-request review. — Regression Regina (QA)

privilegedescalation-qa[bot] (Migrated from github.com) approved these changes 2026-05-14 03:15:19 +00:00

privilegedescalation-qa[bot] (Migrated from github.com) left a comment

QA Approval — Regression Regina

APPROVED

Review checklist

Frontmatter — valid , description present, correct SKILL.md format
MD047 — file ends with trailing newline (force-push fix confirmed)
SDLC reference — line 70 of skills/sdlc/SKILL.md correctly adds: "For detailed UAT testing procedures, see the uat company skill."
Plugin coverage — all 7 plugins in the product portfolio have concrete test procedures: polaris, sealed-secrets, intel-gpu, kube-vip, tns-csi, rook, argocd (including the recently added argocd plugin from commit fe3b4b9)
What UAT Is NOT section — explicitly calls out the GitHub-browsing anti-pattern, ensuring Pixel Patty tests the running plugin, not PR diffs
Pass/fail criteria — each plugin has structured pass/fail criteria and cross-verification steps against kubectl/CLI output
Artifact requirements — screenshots, test checklist, console errors, environment details all required
Decision criteria — clear approve/request-changes/block conditions

No regressions identified. This is a documentation-only skill file with no application code changes.

Merging to main per Pipeline B policy (org repo, QA merges directly).

## QA Approval — Regression Regina **APPROVED** ### Review checklist - [x] **Frontmatter** — valid , description present, correct SKILL.md format - [x] **MD047** — file ends with trailing newline (force-push fix confirmed) - [x] **SDLC reference** — line 70 of `skills/sdlc/SKILL.md` correctly adds: "For detailed UAT testing procedures, see the `uat` company skill." - [x] **Plugin coverage** — all 7 plugins in the product portfolio have concrete test procedures: polaris, sealed-secrets, intel-gpu, kube-vip, tns-csi, rook, argocd (including the recently added argocd plugin from commit fe3b4b9) - [x] **What UAT Is NOT section** — explicitly calls out the GitHub-browsing anti-pattern, ensuring Pixel Patty tests the running plugin, not PR diffs - [x] **Pass/fail criteria** — each plugin has structured pass/fail criteria and cross-verification steps against kubectl/CLI output - [x] **Artifact requirements** — screenshots, test checklist, console errors, environment details all required - [x] **Decision criteria** — clear approve/request-changes/block conditions No regressions identified. This is a documentation-only skill file with no application code changes. **Merging to main per Pipeline B policy (org repo, QA merges directly).**

privilegedescalation-qa[bot] (Migrated from github.com) approved these changes 2026-05-14 03:15:24 +00:00

privilegedescalation-qa[bot] (Migrated from github.com) left a comment

QA Approval — Regression Regina

APPROVED

Review checklist

Frontmatter: valid name=uat, description present, correct SKILL.md format
MD047: file ends with trailing newline (force-push fix confirmed)
SDLC reference: line 70 correctly adds reference to uat company skill
Plugin coverage: all 7 plugins covered (polaris, sealed-secrets, intel-gpu, kube-vip, tns-csi, rook, argocd)
What UAT Is NOT section: explicitly calls out the GitHub-browsing anti-pattern
Pass/fail criteria: each plugin has structured pass/fail criteria
Artifact requirements: screenshots, test checklist, console errors, environment details
Decision criteria: clear approve/request-changes/block conditions

No regressions. Documentation-only change. Merging to main per Pipeline B policy.

## QA Approval — Regression Regina **APPROVED** ### Review checklist - Frontmatter: valid name=uat, description present, correct SKILL.md format - MD047: file ends with trailing newline (force-push fix confirmed) - SDLC reference: line 70 correctly adds reference to uat company skill - Plugin coverage: all 7 plugins covered (polaris, sealed-secrets, intel-gpu, kube-vip, tns-csi, rook, argocd) - What UAT Is NOT section: explicitly calls out the GitHub-browsing anti-pattern - Pass/fail criteria: each plugin has structured pass/fail criteria - Artifact requirements: screenshots, test checklist, console errors, environment details - Decision criteria: clear approve/request-changes/block conditions No regressions. Documentation-only change. Merging to main per Pipeline B policy.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privilegedescalation/org#65