Compare commits
base: cartsnitch/api:betty/car-932-dispose-import-v3
cartsnitch/api:main
cartsnitch/api:uat
cartsnitch/api:dev
cartsnitch/api:betty/car-1362-cache-remove-uat
cartsnitch/api:betty/car-1362-push-unknown-fix
cartsnitch/api:betty/car-1362-remove-gha-cache-dev
cartsnitch/api:betty/car-1330-buildpush-registry-token-dev
cartsnitch/api:betty/car-1330-buildpush-registry-token-uat
cartsnitch/api:betty/car-1330-dev-ci-fix
cartsnitch/api:betty/car-1340-uat-ci-fix
cartsnitch/api:barcode-betty/fix-car-1135-dispose-engine
cartsnitch/api:betty/car-1132-comprehensive-fix
cartsnitch/api:promote/car1077-dev-uat
cartsnitch/api:betty/fix-postgres-pool
cartsnitch/api:betty/fix-sqlite-uuid-server-default
cartsnitch/api:betty/fix-ci-test-failures-v2
cartsnitch/api:remove-deploy-dev-uat-jobs
cartsnitch/api:betty/fix-ci-test-failures
cartsnitch/api:barcode-betty/fix-lint-f402
cartsnitch/api:betty/fix-email-inbound-token-tests
cartsnitch/api:barcode-betty/car-1004-fix-ruff-lint
cartsnitch/api:betty/fix-lint-errors
cartsnitch/api:fix/cart-995-gitea-registry-migration
cartsnitch/api:fix-gitea-registry-migration
cartsnitch/api:betty/car-995-gitea-registry
cartsnitch/api:betty/car-932-dispose-import-v3
cartsnitch/api:barcode-betty/car-995-gitea-registry
cartsnitch/api:betty/car-932-fix-dispose-engine
cartsnitch/api:betty/car-964-gitea-registry-v2
cartsnitch/api:barcode-betty/gitea-registry
cartsnitch/api:barcode-betty/fix-dispose-engine-import
cartsnitch/api:savannah/fix-ci-uat-trigger
cartsnitch/api:barcode-betty/fix-ci-uat-trigger
cartsnitch/api:betty/car-869-gitea-actions-api
cartsnitch/api:betty/car-723-final-review
cartsnitch/api:betty/car-723-ci-workflow
cartsnitch/api:feat/car-723-migrate-api-to-new-repo
..
compare: cartsnitch/api:23899f6c8d7c10184688fc91235faab6c8b9334a
cartsnitch/api:main
cartsnitch/api:uat
cartsnitch/api:dev
cartsnitch/api:betty/car-1362-cache-remove-uat
cartsnitch/api:betty/car-1362-push-unknown-fix
cartsnitch/api:betty/car-1362-remove-gha-cache-dev
cartsnitch/api:betty/car-1330-buildpush-registry-token-dev
cartsnitch/api:betty/car-1330-buildpush-registry-token-uat
cartsnitch/api:betty/car-1330-dev-ci-fix
cartsnitch/api:betty/car-1340-uat-ci-fix
cartsnitch/api:barcode-betty/fix-car-1135-dispose-engine
cartsnitch/api:betty/car-1132-comprehensive-fix
cartsnitch/api:promote/car1077-dev-uat
cartsnitch/api:betty/fix-postgres-pool
cartsnitch/api:betty/fix-sqlite-uuid-server-default
cartsnitch/api:betty/fix-ci-test-failures-v2
cartsnitch/api:remove-deploy-dev-uat-jobs
cartsnitch/api:betty/fix-ci-test-failures
cartsnitch/api:barcode-betty/fix-lint-f402
cartsnitch/api:betty/fix-email-inbound-token-tests
cartsnitch/api:barcode-betty/car-1004-fix-ruff-lint
cartsnitch/api:betty/fix-lint-errors
cartsnitch/api:fix/cart-995-gitea-registry-migration
cartsnitch/api:fix-gitea-registry-migration
cartsnitch/api:betty/car-995-gitea-registry
cartsnitch/api:betty/car-932-dispose-import-v3
cartsnitch/api:barcode-betty/car-995-gitea-registry
cartsnitch/api:betty/car-932-fix-dispose-engine
cartsnitch/api:betty/car-964-gitea-registry-v2
cartsnitch/api:barcode-betty/gitea-registry
cartsnitch/api:barcode-betty/fix-dispose-engine-import
cartsnitch/api:savannah/fix-ci-uat-trigger
cartsnitch/api:barcode-betty/fix-ci-uat-trigger
cartsnitch/api:betty/car-869-gitea-actions-api
cartsnitch/api:betty/car-723-final-review
cartsnitch/api:betty/car-723-ci-workflow
cartsnitch/api:feat/car-723-migrate-api-to-new-repo
2 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
23899f6c8d |
Merge pull request 'fix: remove dead dispose_engine import from API main.py [CAR-932]' (#16) from betty/car-932-fix-dispose-engine into dev
CI / lint (push) Failing after 5s
CI / deploy-uat (pull_request) Has been skipped
CI / test (push) Failing after 10s
CI / build-and-push (push) Has been skipped
CI / deploy-uat (push) Has been skipped
CI / typecheck (push) Failing after 16s
CI / lint (pull_request) Failing after 2s
CI / test (pull_request) Failing after 16s
CI / deploy-dev (pull_request) Has been skipped
CI / deploy-dev (push) Failing after 47s
CI / typecheck (pull_request) Failing after 16s
CI / build-and-push (pull_request) Has been skipped
fix: remove dead dispose_engine import from API main.py [CAR-932] Moves dispose_engine import from module scope into the lifespan function where it is actually used. Fixes ImportError crashing API pods. Reviewed-by: cs_charlie (QA) Approved-by: cs_savannah (CTO) CI-override: pre-existing failures unrelated to this change |
||
|
|
ba88fad48b |
fix: remove dead dispose_engine import from API main.py
CI / lint (pull_request) Failing after 3s
CI / test (pull_request) Failing after 14s
CI / build-and-push (pull_request) Has been skipped
CI / deploy-dev (pull_request) Has been skipped
CI / deploy-uat (pull_request) Has been skipped
CI / typecheck (pull_request) Failing after 20s
The top-level import of dispose_engine from cartsnitch_api.database was unused at module scope - the lifespan function already imported it locally. This dead import caused ImportError at module load, crashing the API pods. Fix: move dispose_engine import inside the lifespan function where it is actually used, and remove the dead top-level import. Co-Authored-By: Paperclip <noreply@paperclip.ing> |