cartsnitch/api
12
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix SQLite CI test failures: UUID binding, func.now() defaults, F402 lint (CAR-1012) #40

Closed
Barcode Betty wants to merge 2 commits from betty/fix-ci-test-failures-v2 into dev
pull from: betty/fix-ci-test-failures-v2
merge into: cartsnitch:dev
Conversation 1 Commits 2 Files Changed 7
+96 -26

2 Commits

Author SHA1 Message Date
Flea Flicker 9fbab62717 Fix SQLite CI test failures: UUID binding, func.now() defaults, F402 lint
CI / lint (pull_request) Failing after 4s
Details
CI / typecheck (pull_request) Failing after 28s
Details
CI / test (pull_request) Failing after 2m37s
Details
CI / build-and-push (pull_request) Has been skipped
Details
CI / deploy-dev (pull_request) Has been skipped
Details
CI / deploy-uat (pull_request) Has been skipped
Details 
Three fixes from PR #35 review:

1. Fix F402: rename loop var 'table' → 'metadata_table' in test_encrypted_json.py
2. Strip func.now() server_defaults in conftest.py engine/db_engine fixtures
3. Add aiosqlite UUID adapter for async engine

Model changes to provide Python-side defaults for SQLite compatibility:
- TimestampMixin: add default=_utcnow for created_at/updated_at
- UUIDPrimaryKeyMixin: use GuidType for cross-DB UUID handling
- User.id: use GuidType() instead of Text, Mapped[uuid.UUID]
- User.email_verified: add default=False
- Purchase.ingested_at: add default=_utcnow
- types.py: add GuidType TypeDecorator for UUID→String conversion

Fixes: CAR-1012
 2026-05-30 09:08:46 +00:00
Barcode Betty 41a887a73b Fix SQLite server_default AttributeError and pool_size errors
CI / lint (pull_request) Failing after 3s
Details
CI / typecheck (pull_request) Failing after 18s
Details
CI / test (pull_request) Failing after 1m30s
Details
CI / build-and-push (pull_request) Has been skipped
Details
CI / deploy-dev (pull_request) Has been skipped
Details
CI / deploy-uat (pull_request) Has been skipped
Details 
- Add hasattr(sd, 'expression') guard in engine fixtures to prevent
  AttributeError when iterating over server_default columns that use
  DefaultClause (which lacks .expression)
- Add _build_engine_kwargs() in database.py to conditionally apply
  pool_size/max_overflow only for non-SQLite database URLs
- Fixes test failures in conftest.py, test_encrypted_json.py

Co-Authored-By: Paperclip <noreply@paperclip.ing>
 2026-05-25 21:46:53 +00:00